gh-111366: Correctly show custom syntax error messages in the codeop module functions #111384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pablogsal
commented
Oct 27, 2023
pablogsal
commented
- Some SyntaxWarning in strings are shown twice in the presence of SyntaxErrors #111380: Show SyntaxWarnings only once when parsing if invalid syntax is encouintered
- Uninformative syntax errors from codeop._maybe_compile (IDLE Shell) #111366: Correctly show custom syntax error messages in the codeop module functions
pablogsal
added
needs backport to 3.11
…odeop module functions
…n the codeop module functions
|
Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
|
Sorry, @pablogsal, I could not cleanly backport this to |
|
Sorry, @pablogsal, I could not cleanly backport this to |
|
GH-111516 is a backport of this pull request to the 3.11 branch. |
pablogsal
added a commit
to pablogsal/cpython
that referenced
this pull request
Oct 30, 2023
…n the codeop module functions (pythonGH-111384). (cherry picked from commit cd6e0a0) Co-authored-by: Pablo Galindo Salgado <[email protected]>
|
GH-111517 is a backport of this pull request to the 3.12 branch. |
pablogsal
added a commit
to pablogsal/cpython
that referenced
this pull request
Oct 30, 2023
…n the codeop module functions (pythonGH-111384). (cherry picked from commit cd6e0a0) Co-authored-by: Pablo Galindo Salgado <[email protected]>
pablogsal
added a commit
to pablogsal/cpython
that referenced
this pull request
Oct 30, 2023
…sages in the codeop module functions (pythonGH-111384). (cherry picked from commit cd6e0a0)
pablogsal
added a commit
to pablogsal/cpython
that referenced
this pull request
Oct 30, 2023
…sages in the codeop module functions (pythonGH-111384). (cherry picked from commit cd6e0a0)
pablogsal
added a commit
that referenced
this pull request
Oct 30, 2023
pablogsal
added a commit
to pablogsal/cpython
that referenced
this pull request
Oct 31, 2023
…n the codeop module functions (pythonGH-111384). (cherry picked from commit cd6e0a0) Co-authored-by: Pablo Galindo Salgado <[email protected]>
pablogsal
added a commit
that referenced
this pull request
Oct 31, 2023
FullteaR
pushed a commit
to FullteaR/cpython
that referenced
this pull request
Nov 3, 2023
…odeop module functions (python#111384)
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…odeop module functions (python#111384)
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…odeop module functions (python#111384)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.