CI: Include Python version in cache.config key #111410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauntsaninja
approved these changes
Oct 27, 2023
ezio-melotti
approved these changes
Oct 28, 2023
hugovk
added
needs backport to 3.11
|
Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 28, 2023
* Include Python version in cache.config key, after Python setup * Remove EOL 3.7 from branch triggers (cherry picked from commit 9d4a1a4) Co-authored-by: Hugo van Kemenade <[email protected]>
|
GH-111421 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 28, 2023
* Include Python version in cache.config key, after Python setup * Remove EOL 3.7 from branch triggers (cherry picked from commit 9d4a1a4) Co-authored-by: Hugo van Kemenade <[email protected]>
|
GH-111422 is a backport of this pull request to the 3.11 branch. |
hugovk
added a commit
that referenced
this pull request
Oct 28, 2023
…11422) CI: Include Python version in cache.config key (GH-111410) * Include Python version in cache.config key, after Python setup * Remove EOL 3.7 from branch triggers (cherry picked from commit 9d4a1a4) Co-authored-by: Hugo van Kemenade <[email protected]>
hugovk
added a commit
that referenced
this pull request
Oct 28, 2023
…11421) CI: Include Python version in cache.config key (GH-111410) * Include Python version in cache.config key, after Python setup * Remove EOL 3.7 from branch triggers (cherry picked from commit 9d4a1a4) Co-authored-by: Hugo van Kemenade <[email protected]>
iritkatriel
pushed a commit
to iritkatriel/cpython
that referenced
this pull request
Oct 29, 2023
* Include Python version in cache.config key, after Python setup * Remove EOL 3.7 from branch triggers
hugovk
added
needs backport to 3.11
|
Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
hugovk
removed
needs backport to 3.12
|
Sorry, @hugovk, I could not cleanly backport this to |
|
Sorry, @hugovk, I could not cleanly backport this to |
|
This was already backported 🙃 |
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
* Include Python version in cache.config key, after Python setup * Remove EOL 3.7 from branch triggers
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
* Include Python version in cache.config key, after Python setup * Remove EOL 3.7 from branch triggers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yesterday, the
actions/setup-pythonupdated the Python version3.xfrom 3.11 to 3.12 which caused build failures in the "Configure CPython" step of thecheck_generated_filesjob:https://github.com/python/cpython/actions/runs/6658472864/job/18096250159
Deleting the
check_generated_files-Linux-52d68ba849d6fda1735c7031561b5102961493401ad71cfb10f4fcbca7a3c9d4file from https://github.com/python/cpython/actions/caches and restarting the job, fixed it (the filename was shown in the "Restore config.cache" step.The root problem is the Python version isn't part of the cache file's key.
We need to include it, so when the version changes, there'll be a new key, and so the old cache file won't be used anymore (and eventually deleted), and a new one will be generated.
So let's add
${{ env.pythonLocation }}to the key used byactions/cache.