Skip to content

gh-111531: Tkinter: fix reference leaks in bind_class() and bind_all() #111533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Oct 31, 2023

Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No leaks, test_tkinter passes, and the changes otherwise look good to me.

@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the tkinter-bind_all branch October 31, 2023 06:48
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 31, 2023
…d_all() (pythonGH-111533)

(cherry picked from commit e3353c4)

Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 31, 2023
…d_all() (pythonGH-111533)

(cherry picked from commit e3353c4)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Oct 31, 2023

GH-111535 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 31, 2023
@bedevere-app
Copy link

bedevere-app bot commented Oct 31, 2023

GH-111536 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Oct 31, 2023
serhiy-storchaka added a commit that referenced this pull request Oct 31, 2023
…nd_all() (GH-111533) (GH-111536)

(cherry picked from commit e3353c4)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this pull request Oct 31, 2023
…nd_all() (GH-111533) (GH-111535)

(cherry picked from commit e3353c4)

Co-authored-by: Serhiy Storchaka <[email protected]>
FullteaR pushed a commit to FullteaR/cpython that referenced this pull request Nov 3, 2023
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants