Skip to content

gh-111615: Fix regression in QueueHandler configuration. #111638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

vsajip
Copy link
Member

@vsajip vsajip commented Nov 2, 2023

@vsajip vsajip added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section 3.12 only security fixes 3.13 bugs and security fixes labels Nov 2, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @vsajip for commit 7d19184 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@vsajip
Copy link
Member Author

vsajip commented Nov 10, 2023

Buildbot failures seem to be either Python build issues, or unrelated failures in test.test_asyncio.test_streams.

@vsajip vsajip merged commit 67655d8 into python:main Dec 27, 2023
@vsajip vsajip deleted the fix-111615 branch December 27, 2023 09:35
@vsajip vsajip added the needs backport to 3.12 only security fixes label Dec 27, 2023
@miss-islington-app
Copy link

Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-app
Copy link

bedevere-app bot commented Dec 27, 2023

GH-113507 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 27, 2023
@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Dec 27, 2023
@brettcannon
Copy link
Member

This broke the WASI builds as multiprocessing isn't available. Opened #113692 to track the breakage.

https://buildbot.python.org/all/#/builders/1046/builds/3844

======================================================================
ERROR: test_111615 (test.test_logging.ConfigDictTest.test_111615)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Lib/test/test_logging.py", line 3934, in test_111615
    'queue': mp.get_context('spawn').Queue(),
             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
  File "/Lib/multiprocessing/context.py", line 102, in Queue
    from .queues import Queue
  File "/Lib/multiprocessing/queues.py", line 23, in <module>
    import _multiprocessing
ModuleNotFoundError: No module named '_multiprocessing'
----------------------------------------------------------------------

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.12 only security fixes 3.13 bugs and security fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants