gh-111881: Import lazily linecache in traceback #111886
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The linecache module is only used by StackSummary and FrameSummary.line property. Import the linecache module lazily to speedup Python imports and reduce the number of imports when the traceback module is imported.
|
It's possible to fix the test by skipping linecache in traceback during Python shutdown by catching ImportError and not providing the source code in the traceback. But currently it works, so do we need to keep this feature? It's hard to write reliable code during Python shutdown. |
|
I lost track of this change, so I just close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The linecache module is only used by StackSummary and FrameSummary.line property. Import the linecache module lazily to speedup Python imports and reduce the number of imports when the traceback module is imported.