Skip to content

[3.12] gh-111881: Use lazy import in test.support (#111885) #111890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2023
Merged

[3.12] gh-111881: Use lazy import in test.support (#111885) #111890

merged 1 commit into from
Nov 9, 2023

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Nov 9, 2023 •
edited by bedevere-app bot
Loading

  • Import lazily getpass in test.support
  • Only import ctypes on Windows in test.support.os_helper.

(cherry picked from commit 0372e3b)

@vstinner
pythongh-111881: Use lazy import in test.support (python#111885)
2a5829b 
* Import lazily getpass in test.support
* Only import ctypes on Windows in test.support.os_helper.

(cherry picked from commit 0372e3b)
@vstinner vstinner added the needs backport to 3.11 only security fixes label Nov 9, 2023
@bedevere-app bedevere-app bot mentioned this pull request Nov 9, 2023
Closed
@bedevere-app bedevere-app bot mentioned this pull request Nov 9, 2023
Merged
@vstinner vstinner enabled auto-merge (squash) November 9, 2023 14:50
@vstinner vstinner merged commit e983ca8 into python:3.12 Nov 9, 2023
@vstinner vstinner deleted the import_support12 branch November 9, 2023 15:23
@miss-islington-app
Copy link

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @vstinner, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker e983ca859de279682631dbb13b959f14a7d89a7b 3.11

@bedevere-app
Copy link

bedevere-app bot commented Nov 9, 2023

GH-111902 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Nov 9, 2023
vstinner added a commit that referenced this pull request Nov 9, 2023
@vstinner
[3.11] gh-111881: Use lazy import in test.support (#111885) (#111890) (…
f108976 
…#111902)

[3.12] gh-111881: Use lazy import in test.support (#111885) (#111890)

gh-111881: Use lazy import in test.support (#111885)

* Import lazily getpass in test.support

Backport to 3.11: test.support.os_helper is unchanged.

(cherry picked from commit 0372e3b)
(cherry picked from commit e983ca8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees

@vstinner vstinner

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstinner @AlexWaygood