Skip to content

[3.11] gh-111777: Fix assertion errors on incorrectly still-tracked GC object destruction (GH-111778) #111990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 17, 2024
Merged

[3.11] gh-111777: Fix assertion errors on incorrectly still-tracked GC object destruction (GH-111778) #111990

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd5e2a9
gh-111777: Fix assertion errors on incorrectly still-tracked GC objec…
Yhg1s Nov 12, 2023
3a1471c
Update gcmodule.c
Yhg1s Nov 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Modules/gcmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2347,14 +2347,18 @@ PyObject_GC_Del(void *op)
size_t presize = _PyType_PreHeaderSize(((PyObject *)op)->ob_type);
PyGC_Head *g = AS_GC(op);
if (_PyObject_GC_IS_TRACKED(op)) {
gc_list_remove(g);
#ifdef Py_DEBUG
PyObject *exc, *exc_value, *exc_tb;
PyErr_Fetch(&exc, &exc_value, &exc_tb);
if (PyErr_WarnExplicitFormat(PyExc_ResourceWarning, "gc", 0,
"gc", NULL, "Object of type %s is not untracked before destruction",
((PyObject*)op)->ob_type->tp_name)) {
PyErr_WriteUnraisable(NULL);
}
if (exc != NULL)
PyErr_Restore(exc, exc_value, exc_tb);
#endif
gc_list_remove(g);
}
GCState *gcstate = get_gc_state();
if (gcstate->generations[0].count > 0) {
Expand Down