Skip to content

gh-112001: Fix test_builtins_have_signatures in test_inspect #112002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2023
Merged

gh-112001: Fix test_builtins_have_signatures in test_inspect #112002

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 7 additions & 12 deletions Lib/test/test_inspect/test_inspect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4733,19 +4733,14 @@ def test_builtins_have_signatures(self):
# These have unrepresentable parameter default values of NULL
needs_null = {"anext"}
no_signature |= needs_null
# These need PEP 457 groups or a signature change to accept None
needs_semantic_update = {"round"}
no_signature |= needs_semantic_update
# These need *args support in Argument Clinic
needs_varargs = {"breakpoint", "min", "max", "print",
"__build_class__"}
needs_varargs = {"breakpoint", "min", "max", "__build_class__"}
no_signature |= needs_varargs
# These simply weren't covered in the initial AC conversion
# for builtin callables
not_converted_yet = {"open", "__import__"}
no_signature |= not_converted_yet
# These builtin types are expected to provide introspection info
types_with_signatures = set()
types_with_signatures = {
'complex', 'enumerate', 'float', 'list', 'memoryview', 'object',
'property', 'reversed', 'tuple',
}
# Check the signatures we expect to be there
ns = vars(builtins)
for name, obj in sorted(ns.items()):
Expand All @@ -4764,9 +4759,9 @@ def test_builtins_have_signatures(self):
# This ensures this test will start failing as more signatures are
# added, so the affected items can be moved into the scope of the
# regression test above
for name in no_signature:
for name in no_signature - needs_null:
with self.subTest(builtin=name):
self.assertIsNone(obj.__text_signature__)
self.assertIsNone(ns[name].__text_signature__)

def test_python_function_override_signature(self):
def func(*args, **kwargs):
Expand Down