Skip to content

gh-94722: fix DocTest.__eq__ for case of no line number on one side #112385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2023
Merged

gh-94722: fix DocTest.__eq__ for case of no line number on one side #112385

merged 1 commit into from
Nov 25, 2023

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Nov 24, 2023 •
edited
Loading

@bedevere-app bedevere-app bot mentioned this pull request Nov 24, 2023
Closed
@iritkatriel iritkatriel added type-bug An unexpected behavior, bug, or error stdlib Python modules in the Lib dir needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Nov 24, 2023
AlexWaygood
AlexWaygood approved these changes Nov 25, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iritkatriel iritkatriel merged commit fbb9027 into python:main Nov 25, 2023
@miss-islington-app
Copy link

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 25, 2023
@iritkatriel @miss-islington
pythongh-94722: fix DocTest.__eq__ for case of no line number on one …
3e7b6b4 
…side (pythonGH-112385)

(cherry picked from commit fbb9027)

Co-authored-by: Irit Katriel <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Nov 25, 2023

GH-112400 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 25, 2023
@iritkatriel @miss-islington
pythongh-94722: fix DocTest.__eq__ for case of no line number on one …
c2b32b3 
…side (pythonGH-112385)

(cherry picked from commit fbb9027)

Co-authored-by: Irit Katriel <[email protected]>
@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Nov 25, 2023
@bedevere-app
Copy link

bedevere-app bot commented Nov 25, 2023

GH-112401 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Nov 25, 2023
iritkatriel added a commit that referenced this pull request Nov 25, 2023
@miss-islington @iritkatriel
[3.11] gh-94722: fix DocTest.__eq__ for case of no line number on one…
8c9f273 
… side (GH-112385) (#112401)

gh-94722: fix DocTest.__eq__ for case of no line number on one side (GH-112385)
(cherry picked from commit fbb9027)

Co-authored-by: Irit Katriel <[email protected]>
iritkatriel added a commit that referenced this pull request Nov 25, 2023
@miss-islington @iritkatriel
[3.12] gh-94722: fix DocTest.__eq__ for case of no line number on one…
e93af80 
… side (GH-112385) (#112400)

gh-94722: fix DocTest.__eq__ for case of no line number on one side (GH-112385)
(cherry picked from commit fbb9027)

Co-authored-by: Irit Katriel <[email protected]>
@iritkatriel iritkatriel deleted the doctest-no-lno branch November 28, 2023 12:45
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@iritkatriel @aisk
pythongh-94722: fix DocTest.__eq__ for case of no line number on one …
e2f3f28 
…side (python#112385)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@iritkatriel @Glyphack
pythongh-94722: fix DocTest.__eq__ for case of no line number on one …
9446cba 
…side (python#112385)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DocTest sorts by lineno which may be int or None
2 participants
@iritkatriel @AlexWaygood