gh-112278: reduce time cost for platform module when no permission to WMI on Windows #112658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zooba
reviewed
Dec 4, 2023
Lib/platform.py
Outdated
Comment on lines
332
to
335
| global _wmi_query | ||
| def _wmi_query(table, *keys): | ||
| raise OSError("not supported") | ||
| raise OSError("not supported") |
There was a problem hiding this comment.
Let's restructure this import block to make _wmi = None when it fails to import, and then if we fail to query it can clear out _wmi and subsequent calls will act as if it were never imported.
|
Updated, ready for review. |
|
Will add the backport to 3.12 after 3.12.1 has settled. |
aisk
added a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using an
Eventobject to simulate timeout forIWbemLocator::ConnectServer. I set it to 100ms, and it's enough for the normal path on my machine. And there have another 100ms plus for waiting the query thread. The final time usage on my local machine: