gh-87319: Simplify TemporaryDirectory cleanup using os.path.isjunction() #112791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 7, 2023
…unction() (pythonGH-112791) (cherry picked from commit ba18893) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-112845 is a backport of this pull request to the 3.12 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Dec 7, 2023
…junction() (GH-112791) (GH-112845) (cherry picked from commit ba18893) Co-authored-by: Serhiy Storchaka <[email protected]>
proc-2
reviewed
Dec 9, 2023
Comment on lines
-903
to
+902
| try: | ||
| st = _os.lstat(path) | ||
| except OSError: | ||
| if ignore_errors: | ||
| return | ||
| raise | ||
| if (_stat.S_ISLNK(st.st_mode) or | ||
| not _stat.S_ISDIR(st.st_mode) or | ||
| (hasattr(st, 'st_file_attributes') and | ||
| st.st_file_attributes & _stat.FILE_ATTRIBUTE_REPARSE_POINT and | ||
| st.st_reparse_tag == _stat.IO_REPARSE_TAG_MOUNT_POINT) | ||
| ): | ||
| if not _os.path.isdir(path) or _os.path.isjunction(path): |
There was a problem hiding this comment.
I assume "TOCTOU" issues are out-of-scope here (both in the original implementation and the simplified one) since it is perfectly fine to handle any concurrent modification of the current directory with "undefined behaviour"?
There was a problem hiding this comment.
It is the best that we can do with the current API. I will consider supporting a new error handler interface that accepts dir_fd and the relative path.
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @eryksun in #29940 (comment).