Skip to content

gh-59616: Support os.chmod(follow_symlinks=True) and os.lchmod() on Windows #113049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Dec 14, 2023
Merged

gh-59616: Support os.chmod(follow_symlinks=True) and os.lchmod() on Windows #113049

merged 14 commits into from
Dec 14, 2023
+93 −28

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Dec 13, 2023 •
edited by bedevere-app bot
Loading

@serhiy-storchaka serhiy-storchaka added type-feature A feature request or enhancement OS-windows labels Dec 13, 2023
@bedevere-app bedevere-app bot mentioned this pull request Dec 13, 2023
Closed
@serhiy-storchaka
pythongh-59616: Support os.chmod(follow_symlinks=True) and os.lchmod(…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
0d117a1 
…) on Windows
@serhiy-storchaka serhiy-storchaka force-pushed the win-chmod-follow-symlinks branch from 15c667b to 0d117a1 Compare December 13, 2023 11:50
@serhiy-storchaka serhiy-storchaka marked this pull request as ready for review December 13, 2023 15:09
@AlexWaygood AlexWaygood removed their request for review December 13, 2023 16:51
erlend-aasland
erlend-aasland reviewed Dec 13, 2023
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with two PEP-7 nits and two cases where we should be explicitly ignoring the return value (-Wunused-result).

@serhiy-storchaka serhiy-storchaka merged commit 29f7eb4 into python:main Dec 14, 2023
@serhiy-storchaka serhiy-storchaka deleted the win-chmod-follow-symlinks branch December 14, 2023 11:28
corona10 pushed a commit to corona10/cpython that referenced this pull request Dec 15, 2023
@serhiy-storchaka @corona10
pythongh-59616: Support os.chmod(follow_symlinks=True) and os.lchmod(…
4f84b76 
…) on Windows (pythonGH-113049)
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@serhiy-storchaka @aisk
pythongh-59616: Support os.chmod(follow_symlinks=True) and os.lchmod(…
ec13685 
…) on Windows (pythonGH-113049)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@serhiy-storchaka @Glyphack
pythongh-59616: Support os.chmod(follow_symlinks=True) and os.lchmod(…
2f01618 
…) on Windows (pythonGH-113049)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland

Assignees
No one assigned
Labels
OS-windows type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@serhiy-storchaka @erlend-aasland