gh-113078: Use uint64 for dev_t and uint32 for makedev params #113080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
renatoalencar
force-pushed
the
unsigned-device-ids
branch
from
e15eed5 to
d0f020f
Compare
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
renatoalencar
force-pushed
the
unsigned-device-ids
branch
from
af37c2d to
6f65229
Compare
Following the implementions from both FreeBSD and GNU glibc, `PyLong_FromDev should actually be unsigned. This can break on FreeBSD systems using ZFS, since they wouldn't generate device IDs with 56 upper bits randomly, therefore the MSB too. Also, following the documentation from FreeBSD and Linux, `makedev` should accept unsigned 32 bit integers. The reason to that is because on FreeBSD `major` and `minor` can return anything on the 32 bit int range and on Linux it really specifies that it returns a unsigned integer.
renatoalencar
force-pushed
the
unsigned-device-ids
branch
from
6f65229 to
51d5f46
Compare
renatoalencar
changed the title
|
I suggest to continue the work on #31794 which is more complete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the implementions from both FreeBSD and GNU glibc, `PyLong_FromDev should actually be unsigned. This can break on FreeBSD systems using ZFS, since they wouldn't generate device IDs with 56 upper bits randomly, therefore the MSB too.
Also, following the documentation from FreeBSD and Linux,
makedevshould accept unsigned 32 bit integers. The reason to that is because on FreeBSDmajorandminorcan return anything on the 32 bit int range and on Linux it really specifies that it returns a unsigned integer.