Skip to content

Fix trivial typo in test_interpreters #113381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 23, 2023

Conversation

jeff5
Copy link
Contributor

@jeff5 jeff5 commented Dec 21, 2023

Just one letter, but it was making test_interpreters fail to compile.

Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeff5
Copy link
Contributor Author

jeff5 commented Dec 22, 2023

Thanks @ericsnowcurrently . It needs a couple of labels to satisfy Sir Bedevere, which I don't think I can add. The Windows failure appears to be an unrelated fault in a specific helper script on Win32, which isn't an obstacle for me.

@serhiy-storchaka
Copy link
Member

Note that ./python -m test.test_interpreters does nothing in 3.11 and 3.12. It would be nice to fix this.

@jeff5
Copy link
Contributor Author

jeff5 commented Dec 23, 2023

Note that ./python -m test.test_interpreters does nothing in 3.11 and 3.12. It would be nice to fix this.

Is this asking me to add anything to the present PR? IIUC that command works in 3.13a+ thanks to @ericsnowcurrently's repackaging of test_interpreters, with this typo fixed, which seems a different PR.

Is the continuing failure of the Windows build an obstacle to merging?

@serhiy-storchaka
Copy link
Member

Nothing to add to this PR. It will be merged when all checks be passed (the failure of Windows build is a matter of luck).

Since this PR does not have an associated issue, and the issue that turned test_inerpreters into package is already closed, I mentioned it here. It would be nice to make test_inerpreters executable in 3.11 and 3.12 by adding the unittest.main() call. It is also a trivial change. If anybody of you, @jeff5 and @ericsnowcurrently, do this, nice. Otherwise I will do it.

@serhiy-storchaka serhiy-storchaka merged commit 8bce593 into python:main Dec 23, 2023
@jeff5
Copy link
Contributor Author

jeff5 commented Dec 23, 2023

I'd be happy to save you a task. I understand this as:

  • Two PRs, one targeting each maintenance tip.
  • Just PRs (not an issue) because you wrote "trivial".
  • I should use the "backport" style of title for each PR (guidance in the PR template).
  • GitHub will summon @ericsnowcurrently because of the code owners thing and he'll put me right if I'm not.

I see the Windows test has magically gone right just when it was needed. :)

ryan-duve pushed a commit to ryan-duve/cpython that referenced this pull request Dec 26, 2023
kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants