Skip to content

GH-113528: Deoptimise pathlib._abc.PurePathBase.relative_to() #113529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 6, 2024
Merged

GH-113528: Deoptimise pathlib._abc.PurePathBase.relative_to() #113529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9b8d385
GH-113528: Deoptimise `pathlib._abc.PurePathBase.relative_to()`
barneygale Dec 28, 2023
114bd9b
Simplify `PurePath.relative_to()` slightly.
barneygale Dec 29, 2023
12c385f
Merge branch 'main' into gh-113528-deoptimise-relative-to
barneygale Dec 29, 2023
78d950f
Merge branch 'main' into gh-113528-deoptimise-relative-to
barneygale Jan 5, 2024
382ab1e
Merge branch 'main' into gh-113528-deoptimise-relative-to
barneygale Jan 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Lib/pathlib/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,10 @@ def relative_to(self, other, /, *_deprecated, walk_up=False):
"scheduled for removal in Python 3.14")
warnings.warn(msg, DeprecationWarning, stacklevel=2)
other = self.with_segments(other, *_deprecated)
return _abc.PurePathBase.relative_to(self, other, walk_up=walk_up)
path = _abc.PurePathBase.relative_to(self, other, walk_up=walk_up)
path._drv = path._root = ''
path._tail_cached = path._raw_paths.copy()
return path

def is_relative_to(self, other, /, *_deprecated):
"""Return True if the path is relative to another path or False.
Expand Down
2 changes: 1 addition & 1 deletion Lib/pathlib/_abc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@ def relative_to(self, other, *, walk_up=False):
else:
raise ValueError(f"{str(self)!r} and {str(other)!r} have different anchors")
parts = ['..'] * step + self._tail[len(path._tail):]
return self._from_parsed_parts('', '', parts)
return self.with_segments(*parts)

def is_relative_to(self, other):
"""Return True if the path is relative to another path or False.
Expand Down