-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-81094: Refer to PEP 318 in compound_statements.rst #113588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-81094: Refer to PEP 318 in compound_statements.rst #113588
Conversation
…er Function definitions section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good!
Let's give a bit of time before merge in case @slateny want to check it too.
I just did another pull request to fix the sentence. Let me know if you want me to do that other change. I am working tomorrow anyway.
I am eager to contribute, as I work with Machine Learning / AI stuff and business process automation, and so I have ideas about more advanced stuff to contribute (i.e., to things like openpyxl and python-pptx and natural language processing), but I realize I have to start with the easy stuff and then work my way up.
John D. McDonald
PJ Consulting LLCPh. 1-312-945-3518Mobile 1-312-479-2854
On Saturday, December 30, 2023 at 10:49:35 PM CST, Stanley ***@***.***> wrote:
@slateny commented on this pull request.
In Doc/reference/compound_stmts.rst:
@@ -1368,6 +1368,8 @@ access the local variables of the function containing the def. See section
Support for forward references within annotations by preserving
annotations in a string form at runtime instead of eager evaluation.
+ :pep:`318` - Decorators for Functions and Methods
+ Function and method decorators were introduced.
LGTM as well, thanks. Optionally, it might be useful to mirror the "Class definitions" section and also reference PEP 3129 under the "Function definitions" block with something like
⬇️ Suggested change- Function and method decorators were introduced.
+ Function and method decorators were introduced. Class decorators were introduced in :pep:`3129`.
I'll let Hugo decide whether that addition's useful or not 🙂
Since we're changing this section anyways, on line 1365 there's a missing period after variables and instance variables that my suggestion can't quite reach. If you could give that a quick fix, that'd be great too!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
…e_80914_Adding_PEP_318_Reference
b6b5be4
to
5c2ec84
Compare
Ok, I think (hope) I did this correctly. See below. Another reason for volunteering is I am hoping to improve my Github skills. Like I didn't even know you could do more than one commit per pull request.
John D. McDonald
PJ Consulting LLCPh. 1-312-945-3518Mobile 1-312-479-2854
On Sunday, December 31, 2023 at 09:21:40 AM CST, Hugo van Kemenade ***@***.***> wrote:
@hugovk commented on this pull request.
In Doc/reference/compound_stmts.rst:
@@ -1368,6 +1368,8 @@ access the local variables of the function containing the def. See section
Support for forward references within annotations by preserving
annotations in a string form at runtime instead of eager evaluation.
+ :pep:`318` - Decorators for Functions and Methods
+ Function and method decorators were introduced.
Sure, let's include this.
@Rasputin2 Please could you add that? You can click the "Commit suggestion" button to apply this.
And add the period as a new commit in this PR, rather than a new one.
Thanks!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Co-authored-by: Hugo van Kemenade <[email protected]>
I believe I accepted these changes as part of the same PR. So, I think this is done, unless you guys disagree.
John D. McDonald
PJ Consulting LLCPh. 1-312-945-3518Mobile 1-312-479-2854
On Monday, January 1, 2024 at 03:08:05 AM CST, Hugo van Kemenade ***@***.***> wrote:
@hugovk commented on this pull request.
In Doc/reference/compound_stmts.rst:
:pep:`563` - Postponed Evaluation of Annotations
Support for forward references within annotations by preserving
annotations in a string form at runtime instead of eager evaluation.
+ :pep:`318` - Decorators for Functions and Methods
+ Function and method decorators were introduced.
Please add this bit:
⬇️ Suggested change- Function and method decorators were introduced.
+ Function and method decorators were introduced.
+ Class decorators were introduced in :pep:`3129`.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Thanks @Rasputin2 for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
…-113588) (cherry picked from commit 8ff44f8) Co-authored-by: John D. McDonald <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
GH-113643 is a backport of this pull request to the 3.12 branch. |
…-113588) (cherry picked from commit 8ff44f8) Co-authored-by: John D. McDonald <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
GH-113644 is a backport of this pull request to the 3.11 branch. |
…) (#113644) Co-authored-by: John D. McDonald <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
…) (#113643) Co-authored-by: John D. McDonald <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
…13588) Co-authored-by: Hugo van Kemenade <[email protected]>
…13588) Co-authored-by: Hugo van Kemenade <[email protected]>
…13588) Co-authored-by: Hugo van Kemenade <[email protected]>
…er Function definitions section.
📚 Documentation preview 📚: https://cpython-previews--113588.org.readthedocs.build/en/113588/reference/compound_stmts.html