Skip to content

gh-81094: Refer to PEP 318 in compound_statements.rst #113588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 2, 2024

Conversation

Rasputin2
Copy link
Contributor

@Rasputin2 Rasputin2 commented Dec 30, 2023

@ghost
Copy link

ghost commented Dec 30, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Dec 30, 2023
@hugovk hugovk changed the title gh-80914: Adds Reference to PEP 318 in compound_statements.rst gh-81094: Adds Reference to PEP 318 in compound_statements.rst Dec 30, 2023
@hugovk hugovk added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Dec 30, 2023
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

Let's give a bit of time before merge in case @slateny want to check it too.

@Rasputin2
Copy link
Contributor Author

Rasputin2 commented Dec 31, 2023 via email

@Rasputin2 Rasputin2 force-pushed the Issue_80914_Adding_PEP_318_Reference branch from b6b5be4 to 5c2ec84 Compare December 31, 2023 20:22
@Rasputin2
Copy link
Contributor Author

Rasputin2 commented Dec 31, 2023 via email

@Rasputin2
Copy link
Contributor Author

Rasputin2 commented Jan 1, 2024 via email

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hugovk hugovk changed the title gh-81094: Adds Reference to PEP 318 in compound_statements.rst gh-81094: Refer to PEP 318 in compound_statements.rst Jan 2, 2024
@hugovk hugovk merged commit 8ff44f8 into python:main Jan 2, 2024
@miss-islington-app
Copy link

Thanks @Rasputin2 for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 2, 2024
…-113588)

(cherry picked from commit 8ff44f8)

Co-authored-by: John D. McDonald <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jan 2, 2024

GH-113643 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Jan 2, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 2, 2024
…-113588)

(cherry picked from commit 8ff44f8)

Co-authored-by: John D. McDonald <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jan 2, 2024

GH-113644 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Jan 2, 2024
hugovk added a commit that referenced this pull request Jan 2, 2024
…) (#113644)

Co-authored-by: John D. McDonald <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
hugovk added a commit that referenced this pull request Jan 2, 2024
…) (#113643)

Co-authored-by: John D. McDonald <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants