gh-110893: Improve the documentation for __future__ module #114642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nedbat took issue with the phrasing "real module". I'm actually fine with that phrasing, but I do think the `__future__` page should be clear about the way in which the `__future__` module is special. (Yes, there was a footnote linking to the future statements part of the reference, but there should be upfront discussion). I'm sympathetic to nedbat's claim that no one really cares about `__future__._Feature`, so I've moved the interesting table up to the top.
hauntsaninja
added
needs backport to 3.11
JelleZijlstra
approved these changes
Jan 27, 2024
There was a problem hiding this comment.
I like this improvement. Note though #112348 is also open and makes additional (possibly gratuitous) changes.
|
Thanks @hauntsaninja for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 29, 2024
…honGH-114642) nedbat took issue with the phrasing "real module". I'm actually fine with that phrasing, but I do think the `__future__` page should be clear about the way in which the `__future__` module is special. (Yes, there was a footnote linking to the future statements part of the reference, but there should be upfront discussion). I'm sympathetic to nedbat's claim that no one really cares about `__future__._Feature`, so I've moved the interesting table up to the top. (cherry picked from commit 3b86891) Co-authored-by: Shantanu <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 29, 2024
…honGH-114642) nedbat took issue with the phrasing "real module". I'm actually fine with that phrasing, but I do think the `__future__` page should be clear about the way in which the `__future__` module is special. (Yes, there was a footnote linking to the future statements part of the reference, but there should be upfront discussion). I'm sympathetic to nedbat's claim that no one really cares about `__future__._Feature`, so I've moved the interesting table up to the top. (cherry picked from commit 3b86891) Co-authored-by: Shantanu <[email protected]>
|
GH-114702 is a backport of this pull request to the 3.12 branch. |
|
GH-114703 is a backport of this pull request to the 3.11 branch. |
hauntsaninja
added a commit
that referenced
this pull request
Jan 29, 2024
…-114642) (#114703) gh-110893: Improve the documentation for __future__ module (GH-114642) nedbat took issue with the phrasing "real module". I'm actually fine with that phrasing, but I do think the `__future__` page should be clear about the way in which the `__future__` module is special. (Yes, there was a footnote linking to the future statements part of the reference, but there should be upfront discussion). I'm sympathetic to nedbat's claim that no one really cares about `__future__._Feature`, so I've moved the interesting table up to the top. (cherry picked from commit 3b86891) Co-authored-by: Shantanu <[email protected]>
hauntsaninja
added a commit
that referenced
this pull request
Jan 29, 2024
…-114642) (#114702) gh-110893: Improve the documentation for __future__ module (GH-114642) nedbat took issue with the phrasing "real module". I'm actually fine with that phrasing, but I do think the `__future__` page should be clear about the way in which the `__future__` module is special. (Yes, there was a footnote linking to the future statements part of the reference, but there should be upfront discussion). I'm sympathetic to nedbat's claim that no one really cares about `__future__._Feature`, so I've moved the interesting table up to the top. (cherry picked from commit 3b86891) Co-authored-by: Shantanu <[email protected]>
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…hon#114642) nedbat took issue with the phrasing "real module". I'm actually fine with that phrasing, but I do think the `__future__` page should be clear about the way in which the `__future__` module is special. (Yes, there was a footnote linking to the future statements part of the reference, but there should be upfront discussion). I'm sympathetic to nedbat's claim that no one really cares about `__future__._Feature`, so I've moved the interesting table up to the top.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nedbat took issue with the phrasing "real module". I'm actually fine with that phrasing, but I do think the
__future__page should be clear about the way in which the__future__module is special. (Yes, there was a footnote linking to the future statements part of the reference, but there should be upfront discussion).I'm sympathetic to nedbat's claim that no one really cares about
__future__._Feature, so I've moved the interesting table up to the top.📚 Documentation preview 📚: https://cpython-previews--114642.org.readthedocs.build/