Skip to content

gh-115806: Improve configure output #115807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 23, 2024
Merged

gh-115806: Improve configure output #115807

merged 7 commits into from
Feb 23, 2024

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Feb 22, 2024 •
edited
Loading

  • make sure LDLIBRARY and HOSTRUNNER checks don't overlap
  • make the ipv6 library check less subtle
  • always fail if ipv6 library was not found

Configure output before this PR:

$ ./configure
[...]
checking LDLIBRARY... checking HOSTRUNNER...
libpython$(VERSION)$(ABIFLAGS).a
[...]
checking ipv6 stack type... kame
configure: using libc

Configure output with this PR:

$ ./configure
[...]
checking LDLIBRARY... libpython$(VERSION)$(ABIFLAGS).a
checking HOSTRUNNER...
[...]
checking ipv6 stack type... kame
checking ipv6 library... libc

@bedevere-app bedevere-app bot mentioned this pull request Feb 22, 2024
Closed
erlend-aasland
erlend-aasland commented Feb 22, 2024
View reviewed changes
@erlend-aasland erlend-aasland marked this pull request as draft February 22, 2024 09:13
@erlend-aasland erlend-aasland marked this pull request as ready for review February 22, 2024 09:21
@erlend-aasland
Copy link
Contributor Author

@corona10, I left the behaviour changes out and reduced it back to an ux improvement only.

@corona10
Copy link
Member

Yeah I will take a look

corona10
corona10 approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Cool!

@erlend-aasland erlend-aasland merged commit e74cd0f into python:main Feb 23, 2024
@erlend-aasland erlend-aasland deleted the ac/ux branch February 23, 2024 09:52
@erlend-aasland
Copy link
Contributor Author

Thanks for the review!

woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
@erlend-aasland @woodruffw
pythongh-115806: Make configure output more readable (python#115807)
50cf0c4 
- make sure LDLIBRARY and HOSTRUNNER checks don't overlap
- make the ipv6 library check less subtle
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@erlend-aasland @diegorusso
pythongh-115806: Make configure output more readable (python#115807)
bba9ae5 
- make sure LDLIBRARY and HOSTRUNNER checks don't overlap
- make the ipv6 library check less subtle
LukasWoodtli pushed a commit to LukasWoodtli/cpython that referenced this pull request Jan 22, 2025
@erlend-aasland @LukasWoodtli
pythongh-115806: Make configure output more readable (python#115807)
28593e2 
- make sure LDLIBRARY and HOSTRUNNER checks don't overlap
- make the ipv6 library check less subtle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10 corona10 approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erlend-aasland @corona10