Skip to content

gh-115773: Add missing preprocessor guard in _testexternalinspection #116212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

mhsmith
Copy link
Member

@mhsmith mhsmith commented Mar 1, 2024

Android currently uses Clang 17, which by default disables implicit declarations of C functions. This means the call to process_vm_readv in _testexternalinspection.c must be guarded by a preprocessor check, otherwise compilation will fail:

../../../Modules/_testexternalinspection.c:367:16: error: call to undeclared function 'process_vm_readv'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
        read = process_vm_readv(pid, local, 1, remote, 1, 0);
               ^
1 error generated.
make: *** [Modules/_testexternalinspection.o] Error 1

This will eventually affect other platforms as they upgrade Clang.

@mhsmith
Copy link
Member Author

mhsmith commented Mar 1, 2024

This is a trivial fix to a test module, so no news entry is required.

@mhsmith
Copy link
Member Author

mhsmith commented Mar 1, 2024

@pablogsal: FYI

@pablogsal pablogsal enabled auto-merge (squash) March 1, 2024 16:16
@pablogsal
Copy link
Member

Thanks for the PR @mhsmith

@pablogsal pablogsal merged commit e6e3532 into python:main Mar 1, 2024
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
…ction (python#116212)

Add missing preprocessor guard in _testexternalinspection
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
…ction (python#116212)

Add missing preprocessor guard in _testexternalinspection
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
…ction (python#116212)

Add missing preprocessor guard in _testexternalinspection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants