Skip to content

gh-104242: Skip test_is_char_device_true in pathlib test on non posix platform #116904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

gh-104242: Skip test_is_char_device_true in pathlib test on non posix platform #116904

wants to merge 2 commits into from

Conversation

aisk
Copy link
Contributor

@aisk aisk commented Mar 16, 2024 •
edited by bedevere-app bot
Loading

@aisk aisk requested a review from barneygale as a code owner March 16, 2024 13:01
@bedevere-app bedevere-app bot mentioned this pull request Mar 16, 2024
Closed
@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Mar 16, 2024
barneygale
barneygale requested changes Mar 17, 2024
View reviewed changes
@bedevere-app
Copy link

bedevere-app bot commented Mar 17, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!

serhiy-storchaka
serhiy-storchaka reviewed Mar 18, 2024
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use os.devnull?

@aisk
Copy link
Contributor Author

aisk commented Mar 19, 2024

Why not use os.devnull?

Good idea, I'll create another PR with this mechanism for other reviewers to keep a clear review history.

@aisk
Copy link
Contributor Author

aisk commented Mar 19, 2024

See #116983.

@aisk aisk closed this Mar 19, 2024
@aisk aisk mentioned this pull request Mar 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barneygale barneygale barneygale requested changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

Assignees
No one assigned
Labels
awaiting changes skip news tests Tests in the Lib/test dir topic-pathlib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aisk @barneygale @serhiy-storchaka