Skip to content

gh-116145: Updated bundled Tcl/Tk on Windows to 8.6.14 #117030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 31, 2024
Merged

Conversation

zooba
Copy link
Member

@zooba zooba commented Mar 19, 2024

@zooba zooba requested a review from sethmlarson as a code owner March 19, 2024 19:39
@terryjreedy
Copy link
Member

terryjreedy commented Mar 20, 2024

@chrstphrchvz knows about tcl/tk changes.
@serhiy-storchaka is tkinter/ttk code and test maintainer.

Windows x86 test https://github.com/python/cpython/actions/runs/8349119889/job/22852588108?pr=117030

*** test tkinter 2 failures: lines 2001-2061
condensed failure:

FAIL: test_itemconfigure (test.test_tkinter.test_widgets.ListboxTest.test_itemconfigure)
  File "D:\a\cpython\cpython\Lib\test\test_tkinter\test_widgets.py", line 1002, in test_itemconfigure
    self.assertEqual(widget.itemconfigure(0, 'background'),
AssertionError: Tuples differ: ('background', '', '', '', 'red') != ('background', 'background', 'Background', '', 'red')

FAIL: test_configure_tabs (test.test_tkinter.test_widgets.TextTest.test_configure_tabs)
  File "D:\a\cpython\cpython\Lib\test\test_tkinter\test_widgets.py", line 662, in test_configure_tabs
    self.checkParam(widget, 'tabs', '10.2 20.7 1i 2i',
AssertionError: Tuples differ: (10.2, 20.7, <string object: '1i'>, <string object: '2i'>) != ('10.2', '20.7', '1i', '2i')

*** test audit 1 failure, lines 980-1070: Broken pipe error
I know nothing about this. It passed on rerun, same fail, OK on x64, no failure on free-threading builds.
Perhaps ignore for now.

*** test_ttk failed (8 failures) lines 2066-2265
All are same quoting issue: actual (0,) expected as ('0',).

@zooba zooba merged commit 0e8d35b into python:main May 31, 2024
35 checks passed
@zooba zooba deleted the gh-116145 branch May 31, 2024 12:07
@zooba zooba added the needs backport to 3.13 bugs and security fixes label May 31, 2024
@miss-islington-app
Copy link

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 31, 2024
@bedevere-app
Copy link

bedevere-app bot commented May 31, 2024

GH-119847 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 31, 2024
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.12 only security fixes label May 31, 2024
@miss-islington-app
Copy link

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @zooba, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 0e8d35b931f41210483cc51c4169e9a943c7f166 3.12

zooba added a commit that referenced this pull request May 31, 2024
@zooba
Copy link
Member Author

zooba commented May 31, 2024

The macOS change was not backported to 3.12. I don't remember whether we'd consider this a bugfix or a suitable-for-post-beta-pre-RC change, but I'm happy enough to leave it to 3.13 only.

@bedevere-bot

This comment was marked as resolved.

@terryjreedy
Copy link
Member

Hid buildbot failure because test_math and test_statistics not affected by tkinter.

@serhiy-storchaka
Copy link
Member

8.6.14 is a bugfix release. Is there a way for Windows users to update the Tcl/Tk version independently?

@zooba
Copy link
Member Author

zooba commented May 31, 2024

Better discuss on the issue, since the macOS maintainers are almost certainly not watching this PR.

@zooba zooba removed their assignment Jun 3, 2024
serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Jun 12, 2024
@bedevere-app
Copy link

bedevere-app bot commented Jun 12, 2024

GH-120396 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Jun 12, 2024
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants