Skip to content

[3.12] gh-118235: Skip RAISE_SYNTAX_ERROR rules in the grammar spec (GH-118237) #118309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Apr 26, 2024

(cherry picked from commit ef940de)

Co-authored-by: Petr Viktorin [email protected]


📚 Documentation preview 📚: https://cpython-previews--118309.org.readthedocs.build/

@encukou
Copy link
Member

encukou commented Apr 26, 2024

I didn't check the diff of the rendered docs page yet; waiting for the automation to prepare the docs.

@nineteendo
Copy link
Contributor

nineteendo commented Apr 26, 2024

Wouldn't it better to convert the pull request back to a draft? GitHub automatically prevents you from merging those.

Edit: might not be possible if it's not your pull request.

@encukou
Copy link
Member

encukou commented Apr 26, 2024

The diff checks out; the for_if_clause seen in the original PR is new in 3.13.

@@ -498,9 +498,7 @@
 
 type_param:
     | NAME [type_param_bound] 
-    | '*' NAME ':' expression 
     | '*' NAME 
-    | '**' NAME ':' expression 
     | '**' NAME 
 
 type_param_bound: ':' expression 
@@ -801,7 +799,6 @@
 
 starred_expression:
     | '*' expression 
-    | '*' 
 
 kwarg_or_starred:
     | NAME '=' expression 

Wouldn't it better to convert the pull request back to a draft? GitHub automatically prevents you from merging those.

I don't see how it's better than the label that does the same thing.

@encukou encukou merged commit db47460 into python:3.12 Apr 26, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants