gh-118392: Add note about random.random for multi thread app #118396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colesbury
reviewed
Apr 29, 2024
Doc/library/random.rst
Outdated
Comment on lines
297
to
300
| .. warning:: | ||
| Calling this function in the concurrent use can cause performance degradation. | ||
| Instead, Consider using :class:`Random` per thread. | ||
|
|
There was a problem hiding this comment.
Let's move this up to the module level, perhaps between the security warning and the "see also". The advice is not limited this function.
I think maybe a .. note:: is more appropriate. A red "warning" seems a bit severe to me.
For the text, something like:
The global random number generator and instances of :class:`Random` are thread-safe. However,
in the free-threaded build, concurrent calls to the global generator or to the same instance of :class:`Random`
may encounter contention and poor performance. Consider using separate instances of :class:`Random`
per thread instead.
There was a problem hiding this comment.
I agree. This replaces my comment.
terryjreedy
requested changes
Apr 29, 2024
|
When you're done making the requested changes, leave the comment: |
corona10
changed the title
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @terryjreedy: please review the changes made to this pull request. |
rhettinger
approved these changes
Apr 30, 2024
SonicField
pushed a commit
to SonicField/cpython
that referenced
this pull request
May 8, 2024
SonicField
pushed a commit
to SonicField/cpython
that referenced
this pull request
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--118396.org.readthedocs.build/