gh-118418: Use a default value for type_params in typing._eval_type
#118431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you have a prefence: should we add a NEWS entry? On one hand, this is a bugfix, on the other hand, |
I think we don't need to since we never released the (arguably) broken version. |
JelleZijlstra
approved these changes
Apr 30, 2024
|
Thanks @sobolevn for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 30, 2024
…al_type` (pythonGH-118431) (cherry picked from commit 4a5ad84) Co-authored-by: Nikita Sobolev <[email protected]>
|
GH-118436 is a backport of this pull request to the 3.12 branch. |
AlexWaygood
pushed a commit
that referenced
this pull request
Apr 30, 2024
…val_type` (GH-118431) (#118436) Co-authored-by: Nikita Sobolev <[email protected]>
SonicField
pushed a commit
to SonicField/cpython
that referenced
this pull request
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a way for libs using undocumented and protected
_eval_typenot to fail with newly added function parameter.