Skip to content

gh-118928: sqlite3: disallow sequences of params with named placeholders #118929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented May 10, 2024

@erlend-aasland
Copy link
Contributor Author

cc. @felixxm

@erlend-aasland
Copy link
Contributor Author

@hugovk, would you mind taking a look at the What's New entry?

erlend-aasland and others added 2 commits May 11, 2024 16:43
Co-authored-by: Hugo van Kemenade <[email protected]>
@erlend-aasland
Copy link
Contributor Author

Thanks, Hugo!

Copy link
Contributor

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erlend-aasland Thanks 👍

@erlend-aasland
Copy link
Contributor Author

Thanks, Mariusz!

@erlend-aasland
Copy link
Contributor Author

Thanks, Serhiy. I made the diff slightly nicer with 642015e. Enabling auto-merge.

@erlend-aasland erlend-aasland enabled auto-merge (squash) May 14, 2024 15:50
@erlend-aasland erlend-aasland merged commit d8e0e00 into python:main May 14, 2024
36 checks passed
@erlend-aasland erlend-aasland deleted the sqlite/incorrectly-bound-params branch May 14, 2024 16:10
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request May 20, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
…ceholders (python#118929)

Follow-up of pythongh-101693. The previous DeprecationWarning is replaced with 
raising sqlite3.ProgrammingError.

Co-authored-by: Hugo van Kemenade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sqlite3: disallow using a sequence of params with named placeholders
4 participants