gh-119176: Add copy and clear to multiprocessing.ListProxy
#119202
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YvesDup
reviewed
May 20, 2024
| @@ -1155,7 +1155,7 @@ def set(self, value): | |||
| '__add__', '__contains__', '__delitem__', '__getitem__', '__len__', | |||
| '__mul__', '__reversed__', '__rmul__', '__setitem__', | |||
| 'append', 'count', 'extend', 'index', 'insert', 'pop', 'remove', | |||
| 'reverse', 'sort', '__imul__' | |||
| 'reverse', 'sort', '__imul__', 'clear', 'copy', | |||
There was a problem hiding this comment.
Wouldn't it be better to insert these two new strings between 'append' and 'count', to respect alphabetical order?
|
In the meantime bbb4988 got merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that adding
clearis fine, because we already have.removewhich can do the same.I also think that
copymust be added, since this is the only method that is missing fromlist.clearmethod oflistclass inmultiprocessing.Manager()is missing #119176