Skip to content

gh-117865: Defer import of re in ast #119546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 28, 2024
Merged

gh-117865: Defer import of re in ast #119546

merged 2 commits into from
May 28, 2024

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented May 25, 2024 •
edited by bedevere-app bot
Loading

@JelleZijlstra
pythongh-117865: Defer import of re in ast
9cbb64c 
This is used only by ast.get_source_segment(), so it seems sensible to avoid importing it.
@JelleZijlstra JelleZijlstra requested a review from AlexWaygood May 25, 2024 14:26
@bedevere-app bedevere-app bot mentioned this pull request May 25, 2024
Open
@AlexWaygood
Copy link
Member

How much does this speedup the import of inspect? I wouldn't expect it to do much on its own, since inspect itself also imports re. Or is the idea that this could be done in combination with some of the changes in #119526?

@AlexWaygood
Copy link
Member

(Though it's probably worth doing even if it just speeds up the import of ast. I guess I was looking at it through the lens of the github issue it was attached to.)

AlexWaygood
AlexWaygood approved these changes May 25, 2024
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally for me this cuts about 20% off the import time for ast (0.0036s -> 0.0029s), so this seems worth doing. This is especially true since the _splitlines_no_ff function is only ever used in get_source_segment, which is one of the lesser-used ast-module APIs

@JelleZijlstra @AlexWaygood
Update Lib/ast.py
967f7d9 
Co-authored-by: Alex Waygood <[email protected]>
@JelleZijlstra JelleZijlstra merged commit ae11d68 into python:main May 28, 2024
33 checks passed
@JelleZijlstra JelleZijlstra deleted the ast-re branch May 28, 2024 18:04
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@JelleZijlstra @AlexWaygood @estyxx
pythongh-117865: Defer import of re in ast (python#119546)
75e2276 
This is used only by ast.get_source_segment(), so it seems sensible to avoid importing it.

Co-authored-by: Alex Waygood <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@isidentical isidentical Awaiting requested review from isidentical isidentical is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JelleZijlstra @AlexWaygood