Skip to content

gh-119659: Move @no_rerun to test.support #119660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2024
Merged

gh-119659: Move @no_rerun to test.support #119660

merged 1 commit into from
May 28, 2024

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented May 28, 2024 •
edited by bedevere-app bot
Loading

@sobolevn sobolevn requested a review from erlend-aasland May 28, 2024 13:37
@bedevere-app bedevere-app bot mentioned this pull request May 28, 2024
Closed
ericsnowcurrently
ericsnowcurrently approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Do note that we also use a form of this in TestStaticTypes, in Lib/test/test_capi/test_misc.py. It may be worth adapting that to use @no_rerun(), but I'm not opposed to it being done separately (to keep this PR simpler).

@sobolevn
Copy link
Member Author

Thanks! I will send a second PR with that. I will need to test the refactored code, while this one is a no-brainer.

@sobolevn sobolevn merged commit 2da0dc0 into python:main May 28, 2024
@sobolevn sobolevn mentioned this pull request May 28, 2024
Open
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@sobolevn @estyxx
pythongh-119659: Move @no_rerun to test.support (python#119660)
e44c6ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

@Eclips4 Eclips4 Eclips4 approved these changes

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sobolevn @ericsnowcurrently @Eclips4