Skip to content

gh-119655: Fix reference leak in the _datetimemodule.c #119713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 29, 2024
Merged

gh-119655: Fix reference leak in the _datetimemodule.c #119713

merged 3 commits into from
May 29, 2024

Conversation

Eclips4
Copy link
Member

@Eclips4 Eclips4 commented May 29, 2024 •
edited by bedevere-app bot
Loading

@Eclips4 Eclips4 requested review from pganssle and abalkin as code owners May 29, 2024 08:29
@bedevere-app bedevere-app bot mentioned this pull request May 29, 2024
Closed
erlend-aasland
erlend-aasland approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

ericsnowcurrently
ericsnowcurrently approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericsnowcurrently ericsnowcurrently merged commit 34f9b3e into python:main May 29, 2024
36 checks passed
@ericsnowcurrently
Copy link
Member

FYI, I'm going to add this change to gh-119695, which is the backport of gh-119637 to 3.13.

ericsnowcurrently added a commit to miss-islington/cpython that referenced this pull request May 29, 2024
@ericsnowcurrently
pythongh-119655: Fix reference leak in the _datetimemodule.c (pythong…
36aa3f5 
…h-119713)
@Eclips4 Eclips4 deleted the issue-119655 branch May 29, 2024 18:21
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@Eclips4 @noahbkim
pythongh-119655: Fix reference leak in the _datetimemodule.c (pyt…
0761f74 
…hongh-119713)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@Eclips4 @estyxx
pythongh-119655: Fix reference leak in the _datetimemodule.c (pyt…
47be084 
…hongh-119713)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@encukou encukou Awaiting requested review from encukou

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Eclips4 @ericsnowcurrently @erlend-aasland