gh-95144: Improve error message of `... in None` #119888

zware · 2024-05-31T23:01:45Z

Add "container" to the message as a breadcrumb for looking up what's wrong.

Issue: Improve error message when using in for object that is not container #95144

Objects/abstract.c

erlend-aasland · 2024-06-02T21:20:03Z

Sorry for the mess! We can't use PEP-737 formatting here; if so, type_error must be changed to not access tp_name, and all its callers must change :) Sorry!

zware · 2024-06-19T17:23:26Z

@Mariatta, is this change enough to address the issue (gh-95144) in your opinion?

bedevere-bot · 2024-07-12T16:57:06Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot iOS ARM64 Simulator 3.x has failed when building commit dc03ce7.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#builders/1380/builds/800) and take a look at the build logs.
Check if the failure is related to this commit (dc03ce7) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#builders/1380/builds/800

Summary of the results of the build (if available):

Click to see traceback logs

remote: Enumerating objects: 165, done.        
remote: Counting objects:   0% (1/160)        
remote: Counting objects:   1% (2/160)        
remote: Counting objects:   2% (4/160)        
remote: Counting objects:   3% (5/160)        
remote: Counting objects:   4% (7/160)        
remote: Counting objects:   5% (8/160)        
remote: Counting objects:   6% (10/160)        
remote: Counting objects:   7% (12/160)        
remote: Counting objects:   8% (13/160)        
remote: Counting objects:   9% (15/160)        
remote: Counting objects:  10% (16/160)        
remote: Counting objects:  11% (18/160)        
remote: Counting objects:  12% (20/160)        
remote: Counting objects:  13% (21/160)        
remote: Counting objects:  14% (23/160)        
remote: Counting objects:  15% (24/160)        
remote: Counting objects:  16% (26/160)        
remote: Counting objects:  17% (28/160)        
remote: Counting objects:  18% (29/160)        
remote: Counting objects:  19% (31/160)        
remote: Counting objects:  20% (32/160)        
remote: Counting objects:  21% (34/160)        
remote: Counting objects:  22% (36/160)        
remote: Counting objects:  23% (37/160)        
remote: Counting objects:  24% (39/160)        
remote: Counting objects:  25% (40/160)        
remote: Counting objects:  26% (42/160)        
remote: Counting objects:  27% (44/160)        
remote: Counting objects:  28% (45/160)        
remote: Counting objects:  29% (47/160)        
remote: Counting objects:  30% (48/160)        
remote: Counting objects:  31% (50/160)        
remote: Counting objects:  32% (52/160)        
remote: Counting objects:  33% (53/160)        
remote: Counting objects:  34% (55/160)        
remote: Counting objects:  35% (56/160)        
remote: Counting objects:  36% (58/160)        
remote: Counting objects:  37% (60/160)        
remote: Counting objects:  38% (61/160)        
remote: Counting objects:  39% (63/160)        
remote: Counting objects:  40% (64/160)        
remote: Counting objects:  41% (66/160)        
remote: Counting objects:  42% (68/160)        
remote: Counting objects:  43% (69/160)        
remote: Counting objects:  44% (71/160)        
remote: Counting objects:  45% (72/160)        
remote: Counting objects:  46% (74/160)        
remote: Counting objects:  47% (76/160)        
remote: Counting objects:  48% (77/160)        
remote: Counting objects:  49% (79/160)        
remote: Counting objects:  50% (80/160)        
remote: Counting objects:  51% (82/160)        
remote: Counting objects:  52% (84/160)        
remote: Counting objects:  53% (85/160)        
remote: Counting objects:  54% (87/160)        
remote: Counting objects:  55% (88/160)        
remote: Counting objects:  56% (90/160)        
remote: Counting objects:  57% (92/160)        
remote: Counting objects:  58% (93/160)        
remote: Counting objects:  59% (95/160)        
remote: Counting objects:  60% (96/160)        
remote: Counting objects:  61% (98/160)        
remote: Counting objects:  62% (100/160)        
remote: Counting objects:  63% (101/160)        
remote: Counting objects:  64% (103/160)        
remote: Counting objects:  65% (104/160)        
remote: Counting objects:  66% (106/160)        
remote: Counting objects:  67% (108/160)        
remote: Counting objects:  68% (109/160)        
remote: Counting objects:  69% (111/160)        
remote: Counting objects:  70% (112/160)        
remote: Counting objects:  71% (114/160)        
remote: Counting objects:  72% (116/160)        
remote: Counting objects:  73% (117/160)        
remote: Counting objects:  74% (119/160)        
remote: Counting objects:  75% (120/160)        
remote: Counting objects:  76% (122/160)        
remote: Counting objects:  77% (124/160)        
remote: Counting objects:  78% (125/160)        
remote: Counting objects:  79% (127/160)        
remote: Counting objects:  80% (128/160)        
remote: Counting objects:  81% (130/160)        
remote: Counting objects:  82% (132/160)        
remote: Counting objects:  83% (133/160)        
remote: Counting objects:  84% (135/160)        
remote: Counting objects:  85% (136/160)        
remote: Counting objects:  86% (138/160)        
remote: Counting objects:  87% (140/160)        
remote: Counting objects:  88% (141/160)        
remote: Counting objects:  89% (143/160)        
remote: Counting objects:  90% (144/160)        
remote: Counting objects:  91% (146/160)        
remote: Counting objects:  92% (148/160)        
remote: Counting objects:  93% (149/160)        
remote: Counting objects:  94% (151/160)        
remote: Counting objects:  95% (152/160)        
remote: Counting objects:  96% (154/160)        
remote: Counting objects:  97% (156/160)        
remote: Counting objects:  98% (157/160)        
remote: Counting objects:  99% (159/160)        
remote: Counting objects: 100% (160/160)        
remote: Counting objects: 100% (160/160), done.        
remote: Compressing objects:   0% (1/120)        
remote: Compressing objects:   1% (2/120)        
remote: Compressing objects:   2% (3/120)        
remote: Compressing objects:   3% (4/120)        
remote: Compressing objects:   4% (5/120)        
remote: Compressing objects:   5% (6/120)        
remote: Compressing objects:   6% (8/120)        
remote: Compressing objects:   7% (9/120)        
remote: Compressing objects:   8% (10/120)        
remote: Compressing objects:   9% (11/120)        
remote: Compressing objects:  10% (12/120)        
remote: Compressing objects:  11% (14/120)        
remote: Compressing objects:  12% (15/120)        
remote: Compressing objects:  13% (16/120)        
remote: Compressing objects:  14% (17/120)        
remote: Compressing objects:  15% (18/120)        
remote: Compressing objects:  16% (20/120)        
remote: Compressing objects:  17% (21/120)        
remote: Compressing objects:  18% (22/120)        
remote: Compressing objects:  19% (23/120)        
remote: Compressing objects:  20% (24/120)        
remote: Compressing objects:  21% (26/120)        
remote: Compressing objects:  22% (27/120)        
remote: Compressing objects:  23% (28/120)        
remote: Compressing objects:  24% (29/120)        
remote: Compressing objects:  25% (30/120)        
remote: Compressing objects:  26% (32/120)        
remote: Compressing objects:  27% (33/120)        
remote: Compressing objects:  28% (34/120)        
remote: Compressing objects:  29% (35/120)        
remote: Compressing objects:  30% (36/120)        
remote: Compressing objects:  31% (38/120)        
remote: Compressing objects:  32% (39/120)        
remote: Compressing objects:  33% (40/120)        
remote: Compressing objects:  34% (41/120)        
remote: Compressing objects:  35% (42/120)        
remote: Compressing objects:  36% (44/120)        
remote: Compressing objects:  37% (45/120)        
remote: Compressing objects:  38% (46/120)        
remote: Compressing objects:  39% (47/120)        
remote: Compressing objects:  40% (48/120)        
remote: Compressing objects:  41% (50/120)        
remote: Compressing objects:  42% (51/120)        
remote: Compressing objects:  43% (52/120)        
remote: Compressing objects:  44% (53/120)        
remote: Compressing objects:  45% (54/120)        
remote: Compressing objects:  46% (56/120)        
remote: Compressing objects:  47% (57/120)        
remote: Compressing objects:  48% (58/120)        
remote: Compressing objects:  49% (59/120)        
remote: Compressing objects:  50% (60/120)        
remote: Compressing objects:  51% (62/120)        
remote: Compressing objects:  52% (63/120)        
remote: Compressing objects:  53% (64/120)        
remote: Compressing objects:  54% (65/120)        
remote: Compressing objects:  55% (66/120)        
remote: Compressing objects:  56% (68/120)        
remote: Compressing objects:  57% (69/120)        
remote: Compressing objects:  58% (70/120)        
remote: Compressing objects:  59% (71/120)        
remote: Compressing objects:  60% (72/120)        
remote: Compressing objects:  61% (74/120)        
remote: Compressing objects:  62% (75/120)        
remote: Compressing objects:  63% (76/120)        
remote: Compressing objects:  64% (77/120)        
remote: Compressing objects:  65% (78/120)        
remote: Compressing objects:  66% (80/120)        
remote: Compressing objects:  67% (81/120)        
remote: Compressing objects:  68% (82/120)        
remote: Compressing objects:  69% (83/120)        
remote: Compressing objects:  70% (84/120)        
remote: Compressing objects:  71% (86/120)        
remote: Compressing objects:  72% (87/120)        
remote: Compressing objects:  73% (88/120)        
remote: Compressing objects:  74% (89/120)        
remote: Compressing objects:  75% (90/120)        
remote: Compressing objects:  76% (92/120)        
remote: Compressing objects:  77% (93/120)        
remote: Compressing objects:  78% (94/120)        
remote: Compressing objects:  79% (95/120)        
remote: Compressing objects:  80% (96/120)        
remote: Compressing objects:  81% (98/120)        
remote: Compressing objects:  82% (99/120)        
remote: Compressing objects:  83% (100/120)        
remote: Compressing objects:  84% (101/120)        
remote: Compressing objects:  85% (102/120)        
remote: Compressing objects:  86% (104/120)        
remote: Compressing objects:  87% (105/120)        
remote: Compressing objects:  88% (106/120)        
remote: Compressing objects:  89% (107/120)        
remote: Compressing objects:  90% (108/120)        
remote: Compressing objects:  91% (110/120)        
remote: Compressing objects:  92% (111/120)        
remote: Compressing objects:  93% (112/120)        
remote: Compressing objects:  94% (113/120)        
remote: Compressing objects:  95% (114/120)        
remote: Compressing objects:  96% (116/120)        
remote: Compressing objects:  97% (117/120)        
remote: Compressing objects:  98% (118/120)        
remote: Compressing objects:  99% (119/120)        
remote: Compressing objects: 100% (120/120)        
remote: Compressing objects: 100% (120/120), done.        
Receiving objects:   0% (1/165)
Receiving objects:   1% (2/165)
Receiving objects:   2% (4/165)
Receiving objects:   3% (5/165)
Receiving objects:   4% (7/165)
Receiving objects:   5% (9/165)
Receiving objects:   6% (10/165)
Receiving objects:   7% (12/165)
Receiving objects:   8% (14/165)
Receiving objects:   9% (15/165)
Receiving objects:  10% (17/165)
Receiving objects:  11% (19/165)
Receiving objects:  12% (20/165)
Receiving objects:  13% (22/165)
Receiving objects:  14% (24/165)
Receiving objects:  15% (25/165)
Receiving objects:  16% (27/165)
Receiving objects:  17% (29/165)
Receiving objects:  18% (30/165)
Receiving objects:  19% (32/165)
Receiving objects:  20% (33/165)
Receiving objects:  21% (35/165)
Receiving objects:  22% (37/165)
Receiving objects:  23% (38/165)
Receiving objects:  24% (40/165)
Receiving objects:  25% (42/165)
Receiving objects:  26% (43/165)
Receiving objects:  27% (45/165)
Receiving objects:  28% (47/165)
Receiving objects:  29% (48/165)
Receiving objects:  30% (50/165)
Receiving objects:  31% (52/165)
Receiving objects:  32% (53/165)
Receiving objects:  33% (55/165)
Receiving objects:  34% (57/165)
Receiving objects:  35% (58/165)
Receiving objects:  36% (60/165)
Receiving objects:  37% (62/165)
Receiving objects:  38% (63/165)
Receiving objects:  39% (65/165)
Receiving objects:  40% (66/165)
Receiving objects:  41% (68/165)
Receiving objects:  42% (70/165)
Receiving objects:  43% (71/165)
Receiving objects:  44% (73/165)
Receiving objects:  45% (75/165)
Receiving objects:  46% (76/165)
Receiving objects:  47% (78/165)
Receiving objects:  48% (80/165)
Receiving objects:  49% (81/165)
Receiving objects:  50% (83/165)
Receiving objects:  51% (85/165)
Receiving objects:  52% (86/165)
Receiving objects:  53% (88/165)
Receiving objects:  54% (90/165)
Receiving objects:  55% (91/165)
Receiving objects:  56% (93/165)
Receiving objects:  57% (95/165)
Receiving objects:  58% (96/165)
Receiving objects:  59% (98/165)
Receiving objects:  60% (99/165)
Receiving objects:  61% (101/165)
Receiving objects:  62% (103/165)
Receiving objects:  63% (104/165)
Receiving objects:  64% (106/165)
Receiving objects:  65% (108/165)
Receiving objects:  66% (109/165)
Receiving objects:  67% (111/165)
Receiving objects:  68% (113/165)
Receiving objects:  69% (114/165)
Receiving objects:  70% (116/165)
Receiving objects:  71% (118/165)
Receiving objects:  72% (119/165)
Receiving objects:  73% (121/165)
Receiving objects:  74% (123/165)
Receiving objects:  75% (124/165)
Receiving objects:  76% (126/165)
Receiving objects:  77% (128/165)
Receiving objects:  78% (129/165)
Receiving objects:  79% (131/165)
Receiving objects:  80% (132/165)
Receiving objects:  81% (134/165)
Receiving objects:  82% (136/165)
Receiving objects:  83% (137/165)
Receiving objects:  84% (139/165)
Receiving objects:  85% (141/165)
Receiving objects:  86% (142/165)
Receiving objects:  87% (144/165)
Receiving objects:  88% (146/165)
Receiving objects:  89% (147/165)
Receiving objects:  90% (149/165)
Receiving objects:  91% (151/165)
Receiving objects:  92% (152/165)
Receiving objects:  93% (154/165)
Receiving objects:  94% (156/165)
Receiving objects:  95% (157/165)
remote: Total 165 (delta 91), reused 74 (delta 40), pack-reused 5        
Receiving objects:  96% (159/165)
Receiving objects:  97% (161/165)
Receiving objects:  98% (162/165)
Receiving objects:  99% (164/165)
Receiving objects: 100% (165/165)
Receiving objects: 100% (165/165), 735.70 KiB | 7.36 MiB/s, done.
Resolving deltas:   0% (0/91)
Resolving deltas:   1% (1/91)
Resolving deltas:   2% (2/91)
Resolving deltas:   3% (3/91)
Resolving deltas:   4% (4/91)
Resolving deltas:   5% (5/91)
Resolving deltas:   6% (6/91)
Resolving deltas:   7% (7/91)
Resolving deltas:   8% (8/91)
Resolving deltas:   9% (9/91)
Resolving deltas:  10% (10/91)
Resolving deltas:  12% (11/91)
Resolving deltas:  13% (12/91)
Resolving deltas:  14% (13/91)
Resolving deltas:  15% (14/91)
Resolving deltas:  16% (15/91)
Resolving deltas:  17% (16/91)
Resolving deltas:  18% (17/91)
Resolving deltas:  19% (18/91)
Resolving deltas:  20% (19/91)
Resolving deltas:  21% (20/91)
Resolving deltas:  23% (21/91)
Resolving deltas:  24% (22/91)
Resolving deltas:  25% (23/91)
Resolving deltas:  26% (24/91)
Resolving deltas:  27% (25/91)
Resolving deltas:  28% (26/91)
Resolving deltas:  29% (27/91)
Resolving deltas:  30% (28/91)
Resolving deltas:  31% (29/91)
Resolving deltas:  32% (30/91)
Resolving deltas:  34% (31/91)
Resolving deltas:  35% (32/91)
Resolving deltas:  36% (33/91)
Resolving deltas:  37% (34/91)
Resolving deltas:  38% (35/91)
Resolving deltas:  39% (36/91)
Resolving deltas:  40% (37/91)
Resolving deltas:  41% (38/91)
Resolving deltas:  42% (39/91)
Resolving deltas:  43% (40/91)
Resolving deltas:  45% (41/91)
Resolving deltas:  46% (42/91)
Resolving deltas:  47% (43/91)
Resolving deltas:  48% (44/91)
Resolving deltas:  49% (45/91)
Resolving deltas:  50% (46/91)
Resolving deltas:  51% (47/91)
Resolving deltas:  52% (48/91)
Resolving deltas:  53% (49/91)
Resolving deltas:  54% (50/91)
Resolving deltas:  56% (51/91)
Resolving deltas:  57% (52/91)
Resolving deltas:  58% (53/91)
Resolving deltas:  59% (54/91)
Resolving deltas:  60% (55/91)
Resolving deltas:  61% (56/91)
Resolving deltas:  62% (57/91)
Resolving deltas:  63% (58/91)
Resolving deltas:  65% (60/91)
Resolving deltas:  68% (62/91)
Resolving deltas:  69% (63/91)
Resolving deltas:  70% (64/91)
Resolving deltas:  71% (65/91)
Resolving deltas:  72% (66/91)
Resolving deltas:  73% (67/91)
Resolving deltas:  74% (68/91)
Resolving deltas:  75% (69/91)
Resolving deltas:  76% (70/91)
Resolving deltas:  78% (71/91)
Resolving deltas:  79% (72/91)
Resolving deltas:  80% (73/91)
Resolving deltas:  81% (74/91)
Resolving deltas:  82% (75/91)
Resolving deltas:  83% (76/91)
Resolving deltas:  84% (77/91)
Resolving deltas:  85% (78/91)
Resolving deltas:  86% (79/91)
Resolving deltas:  87% (80/91)
Resolving deltas:  89% (81/91)
Resolving deltas:  90% (82/91)
Resolving deltas:  91% (83/91)
Resolving deltas:  92% (84/91)
Resolving deltas:  93% (85/91)
Resolving deltas:  94% (86/91)
Resolving deltas:  95% (87/91)
Resolving deltas:  96% (88/91)
Resolving deltas:  97% (89/91)
Resolving deltas:  98% (90/91)
Resolving deltas: 100% (91/91)
Resolving deltas: 100% (91/91), completed with 28 local objects.
From https://github.com/python/cpython
 * branch                  main       -> FETCH_HEAD
Note: switching to 'dc03ce797ae8786a9711e6ee5dcaadde02c55864'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at dc03ce797a gh-95144: Improve error message of `... in None` (GH-119888)
Switched to and reset branch 'main'

configure: WARNING: -Wtrampolines not supported
configure: WARNING: no system libmpdecimal found; falling back to bundled libmpdecimal (deprecated and scheduled for removal in Python 3.15)
configure: WARNING: pkg-config is missing. Some dependencies may not be detected correctly.

In file included from ../../Python/ceval.c:839:
../../Python/generated_cases.c.h:747:31: warning: code will never be executed [-Wunreachable-code]
                for (int _i = oparg; --_i >= 0;) {
                              ^~~~~
../../Python/generated_cases.c.h:661:31: warning: code will never be executed [-Wunreachable-code]
                for (int _i = oparg*2; --_i >= 0;) {
                              ^~~~~
../../Python/generated_cases.c.h:637:31: warning: code will never be executed [-Wunreachable-code]
                for (int _i = oparg; --_i >= 0;) {
                              ^~~~~
../../Python/generated_cases.c.h:606:31: warning: code will never be executed [-Wunreachable-code]
                for (int _i = oparg; --_i >= 0;) {
                              ^~~~~
4 warnings generated.

configure: WARNING: -Wtrampolines not supported
configure: WARNING: no system libmpdecimal found; falling back to bundled libmpdecimal (deprecated and scheduled for removal in Python 3.15)
configure: WARNING: pkg-config is missing. Some dependencies may not be detected correctly.

../../Modules/_sqlite/connection.c:1307:14: warning: 'sqlite3_create_window_function' is only available on iOS 13.0 or newer [-Wunguarded-availability-new]
        rc = sqlite3_create_window_function(self->db, name, num_params, flags,
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator17.5.sdk/usr/include/sqlite3.h:5533:16: note: 'sqlite3_create_window_function' has been marked as being introduced in iOS 13.0 here, but the deployment target is iOS 12.0.0
SQLITE_API int sqlite3_create_window_function(
               ^
../../Modules/_sqlite/connection.c:1307:14: note: enclose 'sqlite3_create_window_function' in a __builtin_available check to silence this warning
        rc = sqlite3_create_window_function(self->db, name, num_params, flags,
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../Modules/_sqlite/connection.c:1315:14: warning: 'sqlite3_create_window_function' is only available on iOS 13.0 or newer [-Wunguarded-availability-new]
        rc = sqlite3_create_window_function(self->db, name, num_params, flags,
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator17.5.sdk/usr/include/sqlite3.h:5533:16: note: 'sqlite3_create_window_function' has been marked as being introduced in iOS 13.0 here, but the deployment target is iOS 12.0.0
SQLITE_API int sqlite3_create_window_function(
               ^
../../Modules/_sqlite/connection.c:1315:14: note: enclose 'sqlite3_create_window_function' in a __builtin_available check to silence this warning
        rc = sqlite3_create_window_function(self->db, name, num_params, flags,
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 warnings generated.

--- xcodebuild: WARNING: Using the first of multiple matching destinations:
{ platform:iOS Simulator, id:C6AEA11C-C34A-47B8-BD67-AF0403ECA353, OS:17.5, name:iPhone SE (3rd generation) }
{ platform:iOS Simulator, id:C6AEA11C-C34A-47B8-BD67-AF0403ECA353, OS:17.5, name:iPhone SE (3rd generation) }
2024-07-12 16:56:44.252 xcodebuild[78805:109306751] [MT] IDETestOperationsObserverDebug: 907.531 elapsed -- Testing started completed.
2024-07-12 16:56:44.253 xcodebuild[78805:109306751] [MT] IDETestOperationsObserverDebug: 0.000 sec, +0.000 sec -- start
2024-07-12 16:56:44.253 xcodebuild[78805:109306751] [MT] IDETestOperationsObserverDebug: 907.531 sec, +907.531 sec -- end
Failing tests:
	-[iOSTestbedTests testPython]

** TEST FAILED **

make: *** [testios] Error 1

zware requested review from berkerpeksag and erlend-aasland as code owners May 31, 2024 23:01

bedevere-app bot added the awaiting core review label May 31, 2024

bedevere-app bot mentioned this pull request May 31, 2024

Improve error message when using in for object that is not container #95144

Closed

zware force-pushed the fix_contains_error branch from 775fb16 to 1f6e272 Compare May 31, 2024 23:06

erlend-aasland reviewed Jun 1, 2024

View reviewed changes

Objects/abstract.c Show resolved Hide resolved

Objects/abstract.c Show resolved Hide resolved

erlend-aasland reviewed Jun 1, 2024

View reviewed changes

Objects/abstract.c Outdated Show resolved Hide resolved

erlend-aasland reviewed Jun 1, 2024

View reviewed changes

Objects/abstract.c Outdated Show resolved Hide resolved

zware force-pushed the fix_contains_error branch from d1661ae to c5bd52a Compare June 2, 2024 02:34

zware force-pushed the fix_contains_error branch from c5bd52a to 9e26bff Compare June 3, 2024 16:34

pythongh-95144: Improve error message of ... in None

7917ef4

zware force-pushed the fix_contains_error branch from f633fa5 to 7917ef4 Compare June 3, 2024 18:27

zware requested a review from Mariatta June 19, 2024 17:23

Merge branch 'main' into fix_contains_error

ddfefdf

zware enabled auto-merge (squash) July 12, 2024 16:19

zware merged commit dc03ce7 into python:main Jul 12, 2024
36 checks passed

zware deleted the fix_contains_error branch July 12, 2024 16:34

bedevere-app bot removed the awaiting core review label Jul 12, 2024

estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024

pythongh-95144: Improve error message of ... in None (pythonGH-119888)

9e8c146

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

gh-95144: Improve error message of `... in None` #119888

gh-95144: Improve error message of `... in None` #119888

Uh oh!

zware commented May 31, 2024 •

edited by bedevere-app bot

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erlend-aasland commented Jun 2, 2024

Uh oh!

zware commented Jun 19, 2024

Uh oh!

Uh oh!

bedevere-bot commented Jul 12, 2024

Uh oh!

Uh oh!

Uh oh!

gh-95144: Improve error message of ... in None #119888

gh-95144: Improve error message of ... in None #119888

Uh oh!

Conversation

zware commented May 31, 2024 • edited by bedevere-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erlend-aasland commented Jun 2, 2024

Uh oh!

zware commented Jun 19, 2024

Uh oh!

Uh oh!

bedevere-bot commented Jul 12, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Uh oh!

gh-95144: Improve error message of `... in None` #119888

gh-95144: Improve error message of `... in None` #119888

zware commented May 31, 2024 •

edited by bedevere-app bot

Loading