-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-123446: Fix empty function names in TypeError
s in _csv
module (follow-up to gh-123461)
#123462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
BTW, @sobolevn is a core developer and can merge his PRs.
Oh right, for a while sobolevn didn't want to be one :-) Sorry for the early merge! |
@hauntsaninja no worries, no harm done :) |
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
Sorry, @sobolevn, I could not cleanly backport this to
|
Sorry, @sobolevn, I could not cleanly backport this to
|
…_csv` module (pythonGH-123462) (cherry picked from commit 58ce131) Co-authored-by: sobolevn <[email protected]>
GH-123466 is a backport of this pull request to the 3.12 branch. |
TypeError
s in _csv
moduleTypeError
s in _csv
module (follow-up to gh-123461)
I just changed the title otherwise I thought there were twice the same PR on the tracker :') |
I am not sure that it is worth to backport this change. This is just a minor enhancement in error messages. |
Ok, I can close them 👍 |
After:
Follow up to #123461
PyArg_UnpackTuple
is used withname=""
#123446