gh-124960: Fixed `barry_as_FLUFL` future flag does not work in new REPL #124999

Wulian233 · 2024-10-05T07:53:55Z

co-author: nineteendo armv

Issue: barry_as_FLUFL future flag does not work in new REPL #124960

Lib/_pyrepl/console.py

… the beginning of the file (console.py, line 21)

Lib/_pyrepl/console.py

Misc/NEWS.d/next/Library/2024-10-05-15-49-53.gh-issue-124960.Bol9hT.rst

Lib/_pyrepl/console.py

nineteendo · 2024-10-05T21:46:52Z

You can close this, I have a proper fix.

Co-authored-by: Nice Zombies <[email protected]>

Wulian233 · 2024-10-06T06:23:56Z

You can close this, I have a proper fix.

After my testing, your patch solved this bug. I added a co-author, but I need ask your opinion so that we can open one less PR

edit: tests fail.

Lib/_pyrepl/console.py

Co-authored-by: Nice Zombies <[email protected]>

Lib/_pyrepl/console.py

ambv · 2024-10-09T19:01:24Z

Lib/test/test_pyrepl/test_interact.py

+        with contextlib.redirect_stdout(f):
+            result = console.runsource("from __future__ import barry_as_FLUFL\n")
+            result = console.runsource("""print("black" <> 'blue')\n""")


This is required because the parser can't deal with the future import changing the flags inside a run. This is true now:

❯ ./python.exe -c "from __future__ import barry_as_FLUFL; 1<>0" File "<string>", line 1 from __future__ import barry_as_FLUFL; 1<>0 ^^ SyntaxError: invalid syntax

but was also true in the old parser:

❯ python3.9 -Xoldparser -c "from __future__ import barry_as_FLUFL; 1<>0" File "<string>", line 1 from __future__ import barry_as_FLUFL; 1<>0 ^ SyntaxError: invalid syntax

The consequence of that with PyREPL is that you cannot paste multiline blocks with that future and make them run, because PyREPL executes everything save for the last line in one go.

PyREPL isn't doing anything wrong here, it's just exposing the bug that was always there. Therefore, I'm not sure we should be working around this pasting thing for this one future. Other futures work fine, as you can see in the test added above.

miss-islington-app · 2024-10-14T13:54:01Z

Thanks @Wulian233 for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington-app · 2024-10-14T13:54:04Z

Sorry, @Wulian233 and @ambv, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 6a08a753b702ac63c9b6ac58dd204d1fe9662e9d 3.13

bedevere-app · 2024-10-14T17:25:57Z

GH-125475 is a backport of this pull request to the 3.13 branch.

…new REPL (python#124999) Co-authored-by: Nice Zombies <[email protected]> Co-authored-by: Łukasz Langa <[email protected]> (cherry picked from commit 6a08a75)

… new REPL (#124999) (#125475) gh-124960: Fixed `barry_as_FLUFL` future flag does not work in new REPL (#124999) Co-authored-by: Wulian <[email protected]> Co-authored-by: Nice Zombies <[email protected]> Co-authored-by: Łukasz Langa <[email protected]> (cherry picked from commit 6a08a75)

Fixed barry_as_FLUFL future flag does not work in new REPL

77cb340

Wulian233 requested review from pablogsal, lysnikolaou and ambv as code owners October 5, 2024 07:53

bedevere-app bot added the awaiting review label Oct 5, 2024

bedevere-app bot mentioned this pull request Oct 5, 2024

barry_as_FLUFL future flag does not work in new REPL #124960

Closed

nineteendo reviewed Oct 5, 2024

View reviewed changes

Lib/_pyrepl/console.py Outdated Show resolved Hide resolved

Wulian233 marked this pull request as draft October 5, 2024 08:06

bedevere-app bot removed the awaiting review label Oct 5, 2024

picnixz reviewed Oct 5, 2024

View reviewed changes

Lib/_pyrepl/console.py Outdated Show resolved Hide resolved

Lib/_pyrepl/console.py Outdated Show resolved Hide resolved

Wulian233 and others added 2 commits October 5, 2024 17:41

WIP: warning: can't use pyrepl: from __future__ imports must occur at…

9127c6c

… the beginning of the file (console.py, line 21)

Update test_interact.py

d0049a3

picnixz reviewed Oct 5, 2024

View reviewed changes

Lib/_pyrepl/console.py Outdated Show resolved Hide resolved

Misc/NEWS.d/next/Library/2024-10-05-15-49-53.gh-issue-124960.Bol9hT.rst Outdated Show resolved Hide resolved

Lib/_pyrepl/console.py Outdated Show resolved Hide resolved

WIP

904c202

sobolevn reviewed Oct 5, 2024

View reviewed changes

Lib/_pyrepl/console.py Outdated Show resolved Hide resolved

Wulian233 force-pushed the barry_as_FLUFL branch from ce801c7 to 904c202 Compare October 6, 2024 05:56

Wulian233 and others added 2 commits October 6, 2024 14:13

Co-authored-by: Nice Zombies <[email protected]>

cc807ee

Co-authored-by: Nice Zombies <[email protected]>

LF

cf96285

Wulian233 marked this pull request as ready for review October 6, 2024 06:27

bedevere-app bot added the awaiting review label Oct 6, 2024

picnixz reviewed Oct 6, 2024

View reviewed changes

Lib/_pyrepl/console.py Outdated Show resolved Hide resolved

nineteendo reviewed Oct 6, 2024

View reviewed changes

Lib/_pyrepl/console.py Outdated Show resolved Hide resolved

Wulian233 and others added 2 commits October 9, 2024 06:41

Update Lib/_pyrepl/console.py

2080b24

Co-authored-by: Nice Zombies <[email protected]>

Add tests, reformat a little

5dde260

nineteendo reviewed Oct 9, 2024

View reviewed changes

Lib/_pyrepl/console.py Outdated Show resolved Hide resolved

ambv reviewed Oct 9, 2024

View reviewed changes

dont_inherit is only relevant to the built-in compile() func

4bc4bdb

Wulian233 mentioned this pull request Oct 11, 2024

from __future__ import barry_as_FLUFL doesn't work #125331

Closed

ambv merged commit 6a08a75 into python:main Oct 14, 2024
42 checks passed

bedevere-app bot removed the awaiting review label Oct 14, 2024

ambv added the needs backport to 3.13 bugs and security fixes label Oct 14, 2024

miss-islington-app bot assigned ambv Oct 14, 2024

nineteendo mentioned this pull request Oct 14, 2024

[3.13] gh-124960: Fixed barry_as_FLUFL future flag does not work in new RE… #125475

Merged

bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 14, 2024

Wulian233 deleted the barry_as_FLUFL branch October 14, 2024 22:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gh-124960: Fixed `barry_as_FLUFL` future flag does not work in new REPL #124999

gh-124960: Fixed `barry_as_FLUFL` future flag does not work in new REPL #124999

Wulian233 commented Oct 5, 2024 •

edited

Loading

nineteendo commented Oct 5, 2024

Wulian233 commented Oct 6, 2024 •

edited

Loading

ambv Oct 9, 2024

miss-islington-app bot commented Oct 14, 2024

miss-islington-app bot commented Oct 14, 2024

bedevere-app bot commented Oct 14, 2024

gh-124960: Fixed barry_as_FLUFL future flag does not work in new REPL #124999

gh-124960: Fixed barry_as_FLUFL future flag does not work in new REPL #124999

Conversation

Wulian233 commented Oct 5, 2024 • edited Loading

nineteendo commented Oct 5, 2024

Wulian233 commented Oct 6, 2024 • edited Loading

ambv Oct 9, 2024

Choose a reason for hiding this comment

miss-islington-app bot commented Oct 14, 2024

miss-islington-app bot commented Oct 14, 2024

bedevere-app bot commented Oct 14, 2024

gh-124960: Fixed `barry_as_FLUFL` future flag does not work in new REPL #124999

gh-124960: Fixed `barry_as_FLUFL` future flag does not work in new REPL #124999

Wulian233 commented Oct 5, 2024 •

edited

Loading

Wulian233 commented Oct 6, 2024 •

edited

Loading