Skip to content

gh-124927: Fix conversion issue between coordinates and position in REPL #125001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 10, 2025
Merged

gh-124927: Fix conversion issue between coordinates and position in REPL #125001

merged 6 commits into from
Mar 10, 2025

Conversation

ImFeH2
Copy link
Contributor

@ImFeH2 ImFeH2 commented Oct 5, 2024 •
edited
Loading

When encountering non printing characters, there will be 0 in self.screeninfo. Resulting in the setpos_from_xy function getting stuck in a dead loop when pressing the up/down keys, and pos2xy returns an incorrect value when the left/right keys.

@ghost
Copy link

ghost commented Oct 5, 2024 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app bedevere-app bot mentioned this pull request Oct 5, 2024
Closed
@bedevere-app
Copy link

bedevere-app bot commented Oct 5, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@skirpichev
Copy link
Member

Test failures are related to the change.

@ImFeH2 ImFeH2 closed this Oct 5, 2024
@ImFeH2 ImFeH2 reopened this Oct 5, 2024
@ImFeH2 ImFeH2 force-pushed the non-printing-char branch from 1819ec0 to dc3906a Compare October 5, 2024 13:23
@bedevere-app
Copy link

bedevere-app bot commented Oct 5, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@ImFeH2
Copy link
Contributor Author

ImFeH2 commented Oct 5, 2024

All tests have passed, what should I do next?

@picnixz
Copy link
Member

picnixz commented Oct 5, 2024

All tests have passed, what should I do next?

Actually the tests were not executed (someone needed to approve the workflow which I did). So we'll just wait until they are indeed complete.

@ImFeH2 ImFeH2 force-pushed the non-printing-char branch from 9386824 to 429c206 Compare October 9, 2024 01:09
@mattip mattip mentioned this pull request Nov 17, 2024
Open
@ImFeH2
Copy link
Contributor Author

ImFeH2 commented Dec 19, 2024

Hi @pablogsal, would you mind taking a look at this small PR when you have a chance? Thanks in advance!

@ImFeH2 ImFeH2 closed this Jan 5, 2025
@ImFeH2 ImFeH2 deleted the non-printing-char branch January 5, 2025 06:36
@ImFeH2 ImFeH2 restored the non-printing-char branch January 5, 2025 06:38
@ImFeH2 ImFeH2 reopened this Jan 5, 2025
pablogsal
pablogsal reviewed Jan 22, 2025
View reviewed changes
@pablogsal
Copy link
Member

Can you rebase the PR? We can merge it after that and #125001 (comment) is addressed. Thanks for the patience!

@ImFeH2 ImFeH2 force-pushed the non-printing-char branch 2 times, most recently from 4ac9af6 to ab39fbd Compare February 14, 2025 12:10
@pablogsal pablogsal merged commit 6ab5c4a into python:main Mar 10, 2025
47 checks passed
@miss-islington-app
Copy link

Thanks @ImFeH2 for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 10, 2025
@ImFeH2 @miss-islington
pythongh-124927: Fix conversion issue between coordinates and positio…
839fe0d 
…n in REPL (pythonGH-125001)

(cherry picked from commit 6ab5c4a)

Co-authored-by: FeH2 <[email protected]>
@pablogsal
Copy link
Member

Thanks a lot for your contribution! 🎉

@bedevere-app
Copy link

bedevere-app bot commented Mar 10, 2025

GH-131061 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Mar 10, 2025
pablogsal pushed a commit that referenced this pull request Mar 10, 2025
@miss-islington @ImFeH2
[3.13] gh-124927: Fix conversion issue between coordinates and positi…
977af3a 
…on in REPL (GH-125001) (#131061)

gh-124927: Fix conversion issue between coordinates and position in REPL (GH-125001)
(cherry picked from commit 6ab5c4a)

Co-authored-by: FeH2 <[email protected]>
@ImFeH2 ImFeH2 deleted the non-printing-char branch April 9, 2025 10:49
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
@ImFeH2 @seehwan80
pythongh-124927: Fix conversion issue between coordinates and positio…
1821245 
…n in REPL (python#125001)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hroncok hroncok hroncok left review comments

@picnixz picnixz picnixz left review comments

@pablogsal pablogsal pablogsal left review comments

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

@ambv ambv Awaiting requested review from ambv ambv is a code owner

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ImFeH2 @skirpichev @picnixz @pablogsal @hroncok