Skip to content

gh-125447: Remove Py_TPFLAGS_HAVE_FINALIZE macro #125448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

rruuaanng
Copy link
Contributor

@rruuaanng rruuaanng commented Oct 14, 2024

According to typeobj.rst

      .. deprecated:: 3.8
         This flag isn't necessary anymore, as the interpreter assumes the
         :c:member:`~PyTypeObject.tp_finalize` slot is always present in the
         type structure.

@bedevere-app
Copy link

bedevere-app bot commented Oct 14, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@rruuaanng rruuaanng changed the title Remove Py_TPFLAGS_HAVE_FINALIZE macro gh-125447: Remove Py_TPFLAGS_HAVE_FINALIZE macro Oct 14, 2024
@rruuaanng
Copy link
Contributor Author

rruuaanng commented Oct 14, 2024

In fact, I think the corresponding documents should also be deleted. Because removing Py_TPFLAGS_HAVE_FINALIZE without removing the corresponding documentation would confuse users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants