Skip to content

gh-125716: Use A Global Mutex When Initializing Global State For The _interpqueues Module #125803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 21, 2024

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Oct 21, 2024

This includes a drive-by cleanup in _queues_init() and _queues_fini().

This change also applies to the _interpchannels module.

@ericsnowcurrently
Copy link
Member Author

!buildbot AMD64 Arch Linux Usan Function

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 27fcb3c 🤖

The command will test the builders whose names match following regular expression: AMD64 Arch Linux Usan Function

The builders matched are:

  • AMD64 Arch Linux Usan Function PR

@ericsnowcurrently
Copy link
Member Author

The USAN buildbot passed test_interpreter_pool. It could be an intermittent race, but it's been failing fairly consistently on 3.x for several days, so the odds are in my favor. 😄 I'm going to proceed as though this fixes the problem but will monitor to see if there are further failures after this lands.

@ericsnowcurrently
Copy link
Member Author

@ZeroIntensity, would you mind a quick review? Thanks!

Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this works. It's probably worth refactoring channels to use PyMutex over PyThread_type_lock in the future, but this is fine for now.

@ericsnowcurrently ericsnowcurrently merged commit 4848b0b into python:main Oct 21, 2024
36 checks passed
@miss-islington-app
Copy link

Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@ericsnowcurrently ericsnowcurrently deleted the fix-queues-null-mutex branch October 21, 2024 21:50
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 21, 2024
…r The _interpqueues Module (pythongh-125803)

This includes a drive-by cleanup in _queues_init() and _queues_fini().

This change also applies to the _interpchannels module.
(cherry picked from commit 4848b0b)

Co-authored-by: Eric Snow <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Oct 21, 2024

GH-125817 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 21, 2024
ericsnowcurrently added a commit that referenced this pull request Oct 21, 2024
…or the _interpqueues Module (gh-125817)

This includes a drive-by cleanup in _queues_init() and _queues_fini().

This change also applies to the _interpchannels module.

(cherry picked from commit 4848b0b, AKA gh-125803)

Co-authored-by: Eric Snow <[email protected]>
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
…r The _interpqueues Module (pythongh-125803)

This includes a drive-by cleanup in _queues_init() and _queues_fini().

This change also applies to the _interpchannels module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants