-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
gh-125716: Use A Global Mutex When Initializing Global State For The _interpqueues Module #125803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-125716: Use A Global Mutex When Initializing Global State For The _interpqueues Module #125803
Conversation
!buildbot AMD64 Arch Linux Usan Function |
🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 27fcb3c 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
The USAN buildbot passed test_interpreter_pool. It could be an intermittent race, but it's been failing fairly consistently on 3.x for several days, so the odds are in my favor. 😄 I'm going to proceed as though this fixes the problem but will monitor to see if there are further failures after this lands. |
@ZeroIntensity, would you mind a quick review? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this works. It's probably worth refactoring channels to use PyMutex
over PyThread_type_lock
in the future, but this is fine for now.
Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
…r The _interpqueues Module (pythongh-125803) This includes a drive-by cleanup in _queues_init() and _queues_fini(). This change also applies to the _interpchannels module. (cherry picked from commit 4848b0b) Co-authored-by: Eric Snow <[email protected]>
GH-125817 is a backport of this pull request to the 3.13 branch. |
…or the _interpqueues Module (gh-125817) This includes a drive-by cleanup in _queues_init() and _queues_fini(). This change also applies to the _interpchannels module. (cherry picked from commit 4848b0b, AKA gh-125803) Co-authored-by: Eric Snow <[email protected]>
…r The _interpqueues Module (pythongh-125803) This includes a drive-by cleanup in _queues_init() and _queues_fini(). This change also applies to the _interpchannels module.
This includes a drive-by cleanup in
_queues_init()
and_queues_fini()
.This change also applies to the _interpchannels module.