Skip to content

gh-126012: Add __class_getitem__ to memoryview #126013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 27, 2024
Merged

gh-126012: Add __class_getitem__ to memoryview #126013

merged 5 commits into from
Oct 27, 2024

Conversation

brianschubert
Copy link
Contributor

@brianschubert brianschubert commented Oct 26, 2024 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Oct 26, 2024
Closed
picnixz
picnixz reviewed Oct 26, 2024
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpicks. We should also add some versionchanged for memoryview objects saying that they are now generics.

@brianschubert brianschubert requested a review from picnixz October 26, 2024 18:56
picnixz
picnixz approved these changes Oct 26, 2024
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

ZeroIntensity
ZeroIntensity approved these changes Oct 26, 2024
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well hop on the approval train :)

rruuaanng
rruuaanng approved these changes Oct 27, 2024
View reviewed changes
Copy link
Contributor

@rruuaanng rruuaanng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sobolevn
sobolevn approved these changes Oct 27, 2024
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sobolevn sobolevn merged commit dc76a4a into python:main Oct 27, 2024
40 checks passed
@brianschubert brianschubert mentioned this pull request Oct 27, 2024
Closed
picnixz added a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
@brianschubert @picnixz @ZeroIntensity
pythongh-126012: Add __class_getitem__ to memoryview (python#126013)
59f49cf 
Co-authored-by: Bénédikt Tran <[email protected]>
Co-authored-by: Peter Bierma <[email protected]>
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@brianschubert @picnixz
@ZeroIntensity @ebonnal
pythongh-126012: Add __class_getitem__ to memoryview (python#126013)
b4d60e9 
Co-authored-by: Bénédikt Tran <[email protected]>
Co-authored-by: Peter Bierma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

@picnixz picnixz picnixz approved these changes

@furkanonder furkanonder furkanonder approved these changes

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

@rruuaanng rruuaanng rruuaanng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@brianschubert @sobolevn @picnixz @furkanonder @ZeroIntensity @rruuaanng