-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
GH-127154: Remove PGO from JIT CI #127212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Not totally related, |
@alonme
Haha, you're right. The double negative hurt my brain. Updating, thanks! |
Nice, let's also drop LTO though (like PGO, it doesn't actually give us any useful new coverage and just takes forever). How do you feel about also removing the four |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this is like a ~40% reduction in resources spent running JIT CI!
Two more suggestions for cleanup:
@brandtbucher I'm assuming you still wanted to keep
--with-lto
wherever that's used but let me know if you'd also like to strip that out.