Skip to content

GH-127154: Remove PGO from JIT CI #127212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Nov 27, 2024

Conversation

savannahostrowski
Copy link
Member

@savannahostrowski savannahostrowski commented Nov 24, 2024

@brandtbucher I'm assuming you still wanted to keep --with-lto wherever that's used but let me know if you'd also like to strip that out.

@savannahostrowski savannahostrowski linked an issue Nov 24, 2024 that may be closed by this pull request
@alonme
Copy link
Contributor

alonme commented Nov 24, 2024

Not totally related,
However it seems to me that these 2 lines are also unnecessary?

@savannahostrowski savannahostrowski changed the title GH-127154: Remove PGO from JIT CI GH-127154: Remove PGO from debug JIT CI Nov 24, 2024
@savannahostrowski
Copy link
Member Author

savannahostrowski commented Nov 24, 2024

@alonme Hmmm, I don't think so because those lines refer to non-debug builds.

I realized the title of this PR could be misleading, so I updated it to reflect that it is specifically for debug builds.

Haha, you're right. The double negative hurt my brain. Updating, thanks!

@savannahostrowski savannahostrowski changed the title GH-127154: Remove PGO from debug JIT CI GH-127154: Remove PGO fromJIT CI Nov 24, 2024
@savannahostrowski savannahostrowski changed the title GH-127154: Remove PGO fromJIT CI GH-127154: Remove PGO from JIT CI Nov 24, 2024
@brandtbucher
Copy link
Member

Nice, let's also drop LTO though (like PGO, it doesn't actually give us any useful new coverage and just takes forever).

How do you feel about also removing the four *-unknown-linux-gnu/clang builds while we're at it? Clang is supposed to be ABI-compatible with GCC, so it sort of just seems like we're wasting more time with those builds (and getting Clang to work properly on those builds requires setting the CC env var and another tweak or two that I forget).

Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this is like a ~40% reduction in resources spent running JIT CI!

Two more suggestions for cleanup:

@savannahostrowski savannahostrowski merged commit 2247dd0 into python:main Nov 27, 2024
51 checks passed
@savannahostrowski savannahostrowski deleted the gh-127154 branch November 27, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Turn off PGO for JIT CI
3 participants