[3.12] gh-127655: Ensure _SelectorSocketTransport.writelines pauses the protocol if needed (GH-127656)
#127664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the protocol if needed (pythonGH-127656) Ensure `_SelectorSocketTransport.writelines` pauses the protocol if it reaches the high water mark as needed. (cherry picked from commit e991ac8) Co-authored-by: J. Nick Koston <[email protected]> Co-authored-by: Kumar Aditya <[email protected]>
miss-islington
requested review from
1st1,
asvetlov,
gvanrossum,
kumaraditya303 and
willingc
as code owners
kumaraditya303
approved these changes
Dec 6, 2024
|
@kumaraditya303 Thanks for your review and for getting all the versions merged! |
|
Pardon my ignorance, but given that 9aa0deb fixes a security advisory (GHSA-ph84-rcj2-fxxm) how come there's no new release of 3.12? I.e. something >3.12 on the 3.12 branch? Will there be a 3.12.9 that contains this fix? I'm curious because one of my apps uses 3.12.8 and our alerting says the only version that is fixed is 3.14.0a2 which feels a bit too new to switch to. |
|
3.12.9 is expected on Feb 4 (see PEP 693). I don't think we issue emergency releases for GitHub advisories, only for CVEs, and even then I'm not sure what the policy is. If you're really worried that this pattern exists in your code you can try to audit it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure
_SelectorSocketTransport.writelinespauses the protocol if it reaches the high water mark as needed.(cherry picked from commit e991ac8)
Co-authored-by: J. Nick Koston [email protected]
Co-authored-by: Kumar Aditya [email protected]
_SelectorSocketTransport.writelinesis missing a flow control check allowing writes to fill memory until exhausted #127655