Skip to content

gh-128265: support wasi/emscripten on pdb tests, by removing asyncio from pdb tests #128264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 28, 2024
Merged

gh-128265: support wasi/emscripten on pdb tests, by removing asyncio from pdb tests #128264

merged 6 commits into from
Dec 28, 2024

Conversation

graingert
Copy link
Contributor

@graingert graingert commented Dec 25, 2024 •
edited by bedevere-app bot
Loading

@graingert graingert changed the title support wasi/emscripten on pdb tests support wasi/emscripten on pdb tests, by removing asyncio from pdb tests Dec 25, 2024
@graingert graingert changed the title support wasi/emscripten on pdb tests, by removing asyncio from pdb tests gh-128265: support wasi/emscripten on pdb tests, by removing asyncio from pdb tests Dec 25, 2024
@bedevere-app bedevere-app bot mentioned this pull request Dec 25, 2024
Closed
@graingert graingert marked this pull request as ready for review December 25, 2024 22:01
@graingert graingert requested a review from Eclips4 December 26, 2024 09:30
Eclips4
Eclips4 reviewed Dec 28, 2024
View reviewed changes
@graingert graingert requested a review from Eclips4 December 28, 2024 10:03
Eclips4
Eclips4 reviewed Dec 28, 2024
View reviewed changes
@graingert graingert requested a review from Eclips4 December 28, 2024 12:05
Eclips4
Eclips4 approved these changes Dec 28, 2024
View reviewed changes
Copy link
Member

@Eclips4 Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@Eclips4 Eclips4 merged commit aab51c3 into python:main Dec 28, 2024
40 checks passed
@graingert graingert deleted the wasi-emscripten-pdb branch December 28, 2024 18:14
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@graingert @srinivasreddy
pythongh-128265: Support WASI/Emscripten on PDB tests, by removing as…
2d567cc 
…yncio from pdb tests (python#128264)

A part of `Lib/test/test_pdb.py` was previously unable to run on WASI/Emscripten
platforms because it lacked support for `asyncio`.
In fact, these tests could be rewritten without the `asyncio` framework because 
`test_pdb` tests the behavior of coroutines, which are not part of `asyncio`.

Now reliance on the availability of `asyncio` has been removed and
part of `test_pdb` that deals with coroutines working on WASI/Emscripten platforms.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn left review comments

@Eclips4 Eclips4 Eclips4 approved these changes

@gaogaotiantian gaogaotiantian Awaiting requested review from gaogaotiantian gaogaotiantian is a code owner

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@graingert @sobolevn @Eclips4