GH-115776: Rename Py_TPFLAGS_INLINE_VALUES as _Py_TPFLAGS_INLINE_VALUES
#128635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ould not be used by third-party code.
|
There are 2 package using this, but otherwise LGTM https://grep.app/search?q=Py_TPFLAGS_INLINE_VALUES |
|
That's unfortunate. I still think we are better off moving it, as any code using it (except for tools like PySpy) is broken. |
|
Yeah I realised their usage is wrong. Don't think it's even safe to unset the flag after it's been set. |
Fidget-Spinner
approved these changes
Jan 9, 2025
|
How do you check whether a type uses this layout (as in JPype)? The code in JPype is a workaround for earlier breakage. Is there a clean way to do what they need? |
|
Probably too late to get any code changes in for 3.14, and maybe too late to remove it for 3.15. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Py_TPFLAGS_INLINE_VALUESshould not be used when declaring a staticPyTypeObject. It can only be used by the VM when creating a class. It is undocumented, but is exposed inobject.h.This PR adds an underscore prefix to the name to make it clearer that this flag is internal.