-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
bpo-31525: Increase minimum sqlite version number check #12923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
CLA signed now. I don't think an issue number or a news entry is necessary... |
There is https://bugs.python.org/issue31525 which would be appropriate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we've already updated setup.py
, but apparently we weren't... Good catch!
Thanks @LordAro for the PR, and @berkerpeksag for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
GH-12972 is a backport of this pull request to the 3.7 branch. |
(cherry picked from commit ad0daf5) Co-authored-by: Charles Pigott <[email protected]>
(cherry picked from commit ad0daf5) Co-authored-by: Charles Pigott <[email protected]>
Thanks! |
setup.py checks for a minimum version of sqlite when building the _sqlite3 extension, but it checks for 3.0.8, whereas the extension makes use of
sqlite3_prepare_v2
, which was introduced in 3.3.9 - https://sqlite.org/releaselog/3_3_9.htmlThis PR just bumps the required version number, so that possible failures are detected earlier and are more clear
(I know it's still absolutely ancient, but RHEL5...)
https://bugs.python.org/issue31525