gh-111178: fix UBSan failures in Modules/_zoneinfo.c
#129798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah I'm sorry I put this one as ready for review but I learned that _ + capital letter was also UB (#128248 (comment)) so I'll fix them tomorrow. |
encukou
reviewed
Feb 25, 2025
Modules/_zoneinfo.c
Outdated
Comment on lines
59
to
60
| #define PyZoneInfo_ZoneInfo_FAST_CAST(op) ((PyZoneInfo_ZoneInfo *)(op)) | ||
| #define PyZoneInfo_ZoneInfo_CAST(op) PyZoneInfo_ZoneInfo_FAST_CAST(op) |
There was a problem hiding this comment.
This deserves a comment.
Or replacing FAST_CAST uses with direct casts.
There was a problem hiding this comment.
I removed the fast cast macro but added a message in my commit saying that that raw casts don't need something else. I think I've only had fast cast macros when I was writing the date/time/tkinter PRs but I may have introduced that in other PR.
Raw casts were restored when they could be left as is
|
Thank you! |
seehwan
pushed a commit
to seehwan/cpython
that referenced
this pull request
Apr 16, 2025
…H-129798) Fix UBSan failures for `PyZoneInfo_ZoneInfo` Fix semantic naming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the UBSan failures and addresses some minor cosmetic changes. PEP-7 changes were not applied since they could scramble the diff but other semantic changes affecting the signature of touched functions may have been done.