gh-130250: fix regression in traceback.print_last #130318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iritkatriel
added
type-bug
|
Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 19, 2025
) (cherry picked from commit 6c982ae) Co-authored-by: Irit Katriel <[email protected]>
|
GH-130325 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 19, 2025
) (cherry picked from commit 6c982ae) Co-authored-by: Irit Katriel <[email protected]>
|
GH-130326 is a backport of this pull request to the 3.12 branch. |
iritkatriel
added a commit
that referenced
this pull request
Feb 19, 2025
iritkatriel
added a commit
that referenced
this pull request
Feb 19, 2025
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Add the iOS buildbot to the list of affected platforms - it was masked by the pre-existing colorization failure, but this build is the first to include a failure in |
It should be fixed on main. Let me know if not. |
|
@iritkatriel I presume you're referring to the fix from #130329? This build is the most recent (complete) build of main - (triggered by #129591), which should include that fix, but the problem is still there. |
|
I can remove that assertion and just overwrite sys.last_exc, but I don't know if there's another issue this is exposing with some previous test impacting system state. |
|
And you can use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #130250.