gh-130292: Allow for empty simulator list when running iOS testbed #130388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freakboy3742
changed the title
|
!buildbot iOS |
|
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 273833d 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130388%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
|
This will fail iOS CI because of #130384. That failure is unrelated to this change. |
|
!buildbot iOS |
|
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit dbac20c 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130388%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
ned-deily
approved these changes
Feb 25, 2025
|
Thanks @freakboy3742 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 25, 2025
…bed (pythonGH-130388) Adds error handling when there are no pre-existing test simulators. (cherry picked from commit 99088ab) Co-authored-by: Russell Keith-Magee <[email protected]>
|
GH-130532 is a backport of this pull request to the 3.13 branch. |
freakboy3742
added a commit
that referenced
this pull request
Feb 25, 2025
…tbed (GH-130388) (#130532) Adds error handling when there are no pre-existing test simulators. (cherry picked from commit 99088ab) Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Feb 25, 2025
…bed (python#130388) Adds error handling when there are no pre-existing test simulators.
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Feb 25, 2025
…OS testbed (pythonGH-130388) (python#130532) Adds error handling when there are no pre-existing test simulators. (cherry picked from commit 99088ab) Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Mar 16, 2025
…OS testbed (pythonGH-130388) (python#130532) Adds error handling when there are no pre-existing test simulators. (cherry picked from commit 99088ab) Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Mar 16, 2025
…OS testbed (pythonGH-130388) (python#130532) Adds error handling when there are no pre-existing test simulators. (cherry picked from commit 99088ab) Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Mar 16, 2025
…S testbed (pythonGH-130388) (python#130532) Adds error handling when there are no pre-existing test simulators. (cherry picked from commit 99088ab) Co-authored-by: Russell Keith-Magee <[email protected]>
seehwan
pushed a commit
to seehwan/cpython
that referenced
this pull request
Apr 16, 2025
…bed (python#130388) Adds error handling when there are no pre-existing test simulators.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a completely clean Xcode install (such as those provided by CI platforms), the iOS test simulator set can be empty. The iOS simulator management tooling will return error code 1, rather than an empty list of simulators in this case. This prevents the testbed from starting.
This PR catches the return code of 1 and returns an empty list of simulators, so that the simulator detection part of the testbed script can operate as intended on a CI configuration.