Skip to content

gh-130474: Create and implement flaky resource #130489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 17 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Lib/test/libregrtest/cmdline.py
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,8 @@

tzdata - Run tests that require timezone data.

flaky - Run tests that are known to be unreliable/unstable.

To enable all resources except one, use '-uall,-<resource>'. For
example, to run all the tests except for the gui tests, give the
option '-uall,-gui'.
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/libregrtest/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@


ALL_RESOURCES = ('audio', 'curses', 'largefile', 'network',
'decimal', 'cpu', 'subprocess', 'urlfetch', 'gui', 'walltime')
'decimal', 'cpu', 'subprocess', 'urlfetch', 'gui', 'walltime', 'flaky')

# Other resources excluded from --use=all:
#
Expand Down
4 changes: 2 additions & 2 deletions Lib/test/test_glob.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import warnings

from test import support
from test.support import is_wasi, Py_DEBUG
from test.support import is_wasi, Py_DEBUG, requires_resource
from test.support.os_helper import (TESTFN, skip_unless_symlink,
can_symlink, create_empty_file, change_cwd)

Expand Down Expand Up @@ -521,7 +521,7 @@ class SymlinkLoopGlobTests(unittest.TestCase):
# gh-109959: On Linux, glob._isdir() and glob._lexists() can return False
# randomly when checking the "link/" symbolic link.
# https://github.com/python/cpython/issues/109959#issuecomment-2577550700
@unittest.skip("flaky test")
@requires_resource('flaky')
def test_selflink(self):
tempdir = TESTFN + "_dir"
os.makedirs(tempdir)
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Add the ``flaky`` resource for flagging tests with unreliable outcomes
using the :py:deco:`!test.support.required_resource` decorator.
Loading