gh-131434: Improve error reporting for incorrect format in strptime() #131568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
added
needs backport to 3.12
…time() In particularly, fix regression in detecting stray % at the end of the format string.
serhiy-storchaka
force-pushed
the
strptime-bad-format
branch
from
802f440 to
4bff833
Compare
| @@ -0,0 +1 @@ | |||
| Improve error reporting for incorrect format in :func:`time.strptime`. | |||
There was a problem hiding this comment.
Suggested change
| Improve error reporting for incorrect format in :func:`time.strptime`. | |
| Fix error reporting for incorrect format in :func:`time.strptime`. |
It worked before ;-)
Also datetime strptime functions are affected.
I will review it more in detail later. It looks good from a glance
There was a problem hiding this comment.
Fixing the case for ending % is just a part of this PR. It improves error reporting for many more cases.
There was a problem hiding this comment.
I see, It was however also datetime strptimes
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 9, 2025
…time() (pythonGH-131568) In particularly, fix regression in detecting stray % at the end of the format string. (cherry picked from commit 3feac7a) Co-authored-by: Serhiy Storchaka <[email protected]>
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
|
GH-132309 is a backport of this pull request to the 3.13 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Apr 9, 2025
…ptime() (GH-131568) (GH-132309) In particularly, fix regression in detecting stray % at the end of the format string. (cherry picked from commit 3feac7a) Co-authored-by: Serhiy Storchaka <[email protected]>
|
|
|
seehwan
pushed a commit
to seehwan/cpython
that referenced
this pull request
Apr 16, 2025
…time() (pythonGH-131568) In particularly, fix regression in detecting stray % at the end of the format string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particularly, fix regression in detecting stray % at the end of the format string.
datetime.strptimeno longer raisesValueError: stray % in format '%Y %'#131434