-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-132719: Skip multiprocessing test if missing ctypes #132842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Skip test_lock_locked_2processes() if multiprocessing.sharedctypes is missing (need ctypes).
Example of error: https://buildbot.python.org/#/builders/1232/builds/5434
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
I also contacted the FreeBSD buildbot owner to ask him if he can install libffi (ctypes dependency). |
…132842) Skip test_rlock_locked_2processes() if multiprocessing.sharedctypes is missing (need ctypes).
Oh no, I missed the rlock test: I wrote #132846 to skip also the rlock test. |
I can rewrite these tests without |
It seems safer to always use |
I can use a |
Ah, I understood that you asked to choice between |
I understand that there are 2 problems when
That's why I suggest using a |
It's ok to skip tests when ctypes is missing. Ctypes should be available most of the time. |
I merged my PR to skip rlock test to repair FreeBSD buildbots, but feel free to propose a PR if you want to avoid ctypes in the tests. |
It is okay for to skip these test. Thank for the fix |
Skip test_lock_locked_2processes() if multiprocessing.sharedctypes is missing (need ctypes).