Skip to content

gh-132912: Account for race in test_keyboard_interrupt in test_remote_pdb #132929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2025
Merged

gh-132912: Account for race in test_keyboard_interrupt in test_remote_pdb #132929

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f213a8
gh-132912: Account for race in test_keyboard_interrupt in test_remote…
pablogsal Apr 25, 2025
6fab2b3
Update Lib/test/test_remote_pdb.py
pablogsal Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions Lib/test/test_remote_pdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import io
import time
import json
import os
import signal
Expand Down Expand Up @@ -462,8 +463,6 @@ def test_breakpoints(self):
self.assertIn("Function returned: 42", stdout)
self.assertEqual(process.returncode, 0)

# gh-132912: The test fails randomly
@unittest.skipIf(True, "flaky test")
def test_keyboard_interrupt(self):
"""Test that sending keyboard interrupt breaks into pdb."""
synchronizer_sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
Expand Down Expand Up @@ -512,15 +511,22 @@ def bar():
# Wait until execution has continued
synchronizer_sock.accept()[0].close()

# Wait a bit so the remote leaves create_connection(). This is not
# required but makes the rest of the test faster as we will exit the main
# loop immediately by setting iterations to 0.
time.sleep(0.1)

# Inject a script to interrupt the running process
self._send_interrupt(process.pid)
messages = self._read_until_prompt(client_file)

# Verify we got the keyboard interrupt message
interrupt_msg = next(msg['message'] for msg in messages if 'message' in msg)
self.assertIn("bar()", interrupt_msg)
# Verify we got the keyboard interrupt message. Is possible that we get interrupted somewhere
# in bar() or when leving create_connection()
interrupt_msgs = [msg['message'] for msg in messages if 'message' in msg]
expected_msg = [msg for msg in interrupt_msgs if "bar()" in msg or "create_connection()" in msg]
self.assertGreater(len(expected_msg), 0)

# Continue to end
# Continue to end as fast as we can
self._send_command(client_file, "iterations = 0")
self._send_command(client_file, "c")
stdout, _ = process.communicate(timeout=5)
Expand Down
Loading