GH-133171: Prevent combinations of --disable-gil and --enable-experimental-jit (for now)
#133179
Conversation
brandtbucher
commented
Apr 30, 2025
•
brandtbucher
commented
- Issue: Make the JIT thread-safe #133171
brandtbucher
added
build
brandtbucher
requested review from
a team,
savannahostrowski,
erlend-aasland and
corona10
as code owners
brandtbucher
changed the title
--disable-gil *and* --enable-experimental-jit (for now)--disable-gil and --enable-experimental-jit (for now)
|
Probably gonna conflict with GH-131751. @savannahostrowski, you can land that one first. |
| @@ -123,6 +123,13 @@ if "%do_pgo%" EQU "true" if "%platf%" EQU "x64" ( | |||
| ) | |||
| ) | |||
|
|
|||
| if "%UseDisableGil%" EQU "true" if "%UseTIER2%" NEQ "" ( | |||
There was a problem hiding this comment.
Strictly speaking this would be better as target in pythoncore.vcxproj (see the existing _WarnAboutZlib for example), since there's no requirement to use the batch file, and it's very easy to bypass it. (The same goes for the PGO warning above, I don't remember when that was added.)
But it's not a big deal. It's relatively temporary code anyway
There was a problem hiding this comment.
Yeah, this will only be around for 3.14. I could just put an #error in the C source or whatever, but I figure failing early is best.
Besides, it's not like there's anything wrong with enabling both features. It just doesn't work the way you'd expect.
