gh-131798: Split CALL_LEN into several uops #133180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split macro op CALL_LEN into multiple uops including _GUARD_CALLABLE_LEN. This can be removed by the optimizer.
brandtbucher
approved these changes
May 2, 2025
| @@ -1084,10 +1084,18 @@ dummy_func(void) { | |||
| sym_set_const(callable, (PyObject *)&PyUnicode_Type); | |||
| } | |||
|
|
|||
| op(_CALL_LEN, (callable[1], self_or_null[1], args[oparg] -- res)) { | |||
| op(_CALL_LEN, (unused, unused, unused -- res)) { | |||
| res = sym_new_type(ctx, &PyLong_Type); | |||
There was a problem hiding this comment.
One possible improvement for the future: if the top arg is a tuple or a constant str, we can narrow the output to a constant.
There was a problem hiding this comment.
Do you want me to update this PR or shall I do it in a new one?
There was a problem hiding this comment.
Let's land this for 3.14. I can raise a new PR for the improvements
|
Thanks! Can you pull in |
* origin/main: (111 commits) pythongh-91048: Add filename and line number to external inspection routines (pythonGH-133385) pythongh-131178: Add tests for `ast` command-line interface (python#133329) Regenerate pcbuild.sln in Visual Studio 2022 (python#133394) pythongh-133042: disable HACL* HMAC on Emscripten (python#133064) pythongh-133351: Fix remote PDB's multi-line block tab completion (python#133387) pythongh-109700: Improve stress tests for interpreter creation (pythonGH-109946) pythongh-81793: Skip tests for os.link() to symlink on Android (pythonGH-133388) pythongh-126835: Rename `ast_opt.c` to `ast_preprocess.c` and related stuff after moving const folding to the peephole optimizier (python#131830) pythongh-91048: Relax test_async_global_awaited_by to fix flakyness (python#133368) pythongh-132457: make staticmethod and classmethod generic (python#132460) pythongh-132805: annotationlib: Fix handling of non-constant values in FORWARDREF (python#132812) pythongh-132426: Add get_annotate_from_class_namespace replacing get_annotate_function (python#132490) pythongh-81793: Always call linkat() from os.link(), if available (pythonGH-132517) pythongh-122559: Synchronize C and Python implementation of the io module about pickling (pythonGH-122628) pythongh-69605: Add PyREPL import autocomplete feature to 'What's New' (python#133358) bpo-44172: Keep reference to original window in curses subwindow objects (pythonGH-26226) pythonGH-133231: Changes to executor management to support proposed `sys._jit` module (pythonGH-133287) pythongh-133363: Fix Cmd completion for lines beginning with `! ` (python#133364) pythongh-132983: Introduce `_zstd` bindings module (pythonGH-133027) pythonGH-91048: Add utils for printing the call stack for asyncio tasks (python#133284) ...
* origin/main: pythongh-125618: Make FORWARDREF format succeed more often (python#132818)
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split macro op CALL_LEN into multiple uops including _GUARD_CALLABLE_LEN. This can be removed by the optimizer.